From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8426 invoked by alias); 1 Aug 2009 19:20:45 -0000 Received: (qmail 8416 invoked by uid 22791); 1 Aug 2009 19:20:44 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 01 Aug 2009 19:20:35 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 5387D4A004; Sat, 1 Aug 2009 12:20:34 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost2.vmware.com (Postfix) with ESMTP id 310288E5C0; Sat, 1 Aug 2009 12:20:34 -0700 (PDT) Message-ID: <4A749572.7030005@vmware.com> Date: Sat, 01 Aug 2009 19:20:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml , Eli Zaretskii Subject: Re: [RFA/RFC] Add dump and load command to process record and replay References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00005.txt.bz2 Hui Zhu wrote: > Hi, > > This patch add command record dump and record load to make prec can > dump execution log to a file and load it later. And load can work > with core file. > > And I include "mem_entry_not_accessible"(not_replay) patch to this > patch because when replay with core file, some address in lib cannot > be read and write. Augh! No -- please, this is lumping too much together. Smaller, more discrete patches are much easier to review. 1) You already have a patch thread for the memory-not-accessible change -- let's finish that idea there, not lump it in here. 2) I think the idea of saving and restoring the recording to a file is GREAT -- but can you please give us a patch that adds that, by itself. 3) I don't really understand how core files fit into this, but I'd love to discuss that idea in a separate patch thread. It really adds a lot of complexity to this patch, which it seems to me could be much simpler and easier to review if it added only one thing at a time.