From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10044 invoked by alias); 30 Jul 2009 00:41:17 -0000 Received: (qmail 10030 invoked by uid 22791); 30 Jul 2009 00:41:15 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Jul 2009 00:41:06 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id C466E5003; Wed, 29 Jul 2009 17:41:04 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost2.vmware.com (Postfix) with ESMTP id A45A18EA23; Wed, 29 Jul 2009 17:41:04 -0700 (PDT) Message-ID: <4A70EA5C.3090702@vmware.com> Date: Thu, 30 Jul 2009 00:44:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: paawan oza CC: "gdb-patches@sourceware.org" Subject: Re: final i386.floating.record.patch References: <337799.66621.qm@web112517.mail.gq1.yahoo.com> <4A70AD4A.2080604@vmware.com> In-Reply-To: <4A70AD4A.2080604@vmware.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00728.txt.bz2 Michael Snyder wrote: > paawan oza wrote: >> Hi All, >> >> Now the format is modified, and I am submitting the patch, I hope this meets the expectations. >> thank you all for your review comments specially Micahel and Hui. >> please find the patch as follows. > > I'm sorry, Oza, but the patch does not apply. > > bash-3.00$ patch < ~/oza3/i386.floating.record.patch.txt > patching file i386-tdep.c > Hunk #3 succeeded at 4249 with fuzz 1. > Hunk #4 FAILED at 4263. > Hunk #5 FAILED at 4321. > Hunk #6 FAILED at 4330. > Hunk #7 FAILED at 4351. > Hunk #8 FAILED at 4362. > Hunk #9 FAILED at 4414. > Hunk #10 FAILED at 4451. > Hunk #11 FAILED at 4470. > Hunk #12 FAILED at 4489. > Hunk #13 FAILED at 5110. > 10 out of 13 hunks FAILED -- saving rejects to file i386-tdep.c.rej Just thinking about it -- this was the first time that I had trouble applying one of your patches. But I remembered that previously, I always applied your patch from the attachment. This time there was no attachment, so I saved the email message and edited out the email headers. I know you've had a lot of trouble with attachments and patches not applying -- I'd like to get it sorted out if possible. 1) Are you using a Windows machine to send your emails? If so, is it possible that there is a Unix/Linux machine you could try sending from? Your attachments look OK for me, but some people seem to have had problems with them. 2) And are you using cut-and-paste to insert the patches into the body of your email? That would certainly cause problems, because tabs might be changed into spaces (which is exactly what was causing patch to fail for me today).