From: Aleksandar Ristovski <aristovski@qnx.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] nto-tdep.c - adjust addr_low addr_high
Date: Tue, 28 Jul 2009 00:09:00 -0000 [thread overview]
Message-ID: <4A6E141E.1080006@qnx.com> (raw)
In-Reply-To: <200907241425.45805.pedro@codesourcery.com>
Pedro Alves wrote:
> On Wednesday 08 July 2009 15:26:55, Aleksandar Ristovski wrote:
>
>> This adjusts so->addr_low and so->addr_high for proper "info
>> sahredlibrary" output.
>
>> Index: gdb/nto-tdep.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/nto-tdep.c,v
>> retrieving revision 1.34
>> @@ -315,6 +316,10 @@ nto_relocate_section_addresses (struct s
>>
>> sec->addr = nto_truncate_ptr (sec->addr + LM_ADDR (so) - vaddr);
>> sec->endaddr = nto_truncate_ptr (sec->endaddr + LM_ADDR (so) - vaddr);
>> + if (so->addr_low == 0)
>> + so->addr_low = LM_ADDR (so);
>
> Isn't LM_ADDR an offset, not an absolute address?
In our case, it's absolute address of .text (that is why we
subtract vaddr as read from phdr).
>
>> + if (so->addr_high < sec->endaddr)
>> + so->addr_high = sec->endaddr;
>> }
>>
>> /* This is cheating a bit because our linker code is in libc.so. If we
>
Thanks,
--
Aleksandar Ristovski
QNX Software Systems
next prev parent reply other threads:[~2009-07-27 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 14:27 Aleksandar Ristovski
2009-07-21 17:16 ` Aleksandar Ristovski
2009-07-24 15:41 ` Pedro Alves
2009-07-28 0:09 ` Aleksandar Ristovski [this message]
2009-07-28 11:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6E141E.1080006@qnx.com \
--to=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox