Hello Pedro,

Thanks for reviewing.

Pedro Alves wrote:
> On Tuesday 07 July 2009 17:22:39, Aleksandar Ristovski wrote:
> 
>>   Index: gdb/nto-procfs.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/nto-procfs.c,v
>> retrieving revision 1.47
>> diff -u -p -r1.47 nto-procfs.c
>> --- gdb/nto-procfs.c    2 Jul 2009 17:12:25 -0000       1.47
>> +++ gdb/nto-procfs.c    7 Jul 2009 16:16:23 -0000
>> @@ -774,6 +774,39 @@ procfs_xfer_memory (CORE_ADDR memaddr, g
>>    return (nbytes);
>>  }
>>  
>> +static LONGEST
>> +procfs_xfer_partial (struct target_ops *ops, enum target_object object,
>> +                    const char *annex, gdb_byte *readbuf,
>> +                    const gdb_byte *writebuf, ULONGEST offset, LONGEST len)
>> +{
> ....
>> +  if (ops->beneath && ops->beneath->to_xfer_partial)
>> +    return ops->beneath->to_xfer_partial (ops, object, annex, readbuf,
>> +                                         writebuf, offset, len);
> 
> (( Note: It isn't correct to defer to the target beneath for
> TARGET_OBJECT_MEMORY (and similars) objects, but, I see that nto-procfs.c
> is still implementing deprecated_xfer_memory.  ))

Did you want me to make changes here?

>> +  /* For 32-bit architecture, size of auxv_t is 8 bytes.  */
>> +  const unsigned int sizeof_auxv_t = 8;
> 
> NTO doesn't support any 64-bit architecture?

No, not yet.

> 
>> +  enum bfd_endian byte_order;
>> +
>> +  /* Skip over argc, argv and envp... (see comment in ldd.c)  */
>> +  if (target_read_memory (initial_stack + data_ofs, targ32, sizeof (targ32))
>> +      != 0)
>> +    return 0;
> 
> Can you paste here that ldd.c comment too?  You had pasted it in the
> equivalent gdbserver bit.

Done.

> 
> Otherwise, looks fine to me.
> 

Thanks,

-- 
Aleksandar Ristovski
QNX Software Systems

ChangeLog:

* nto-procfs.c (procfs_xfer_partial): New function.
(init_procfs_ops): Register to_xfer_partial.
* nto-tdep.c (nto_read_auxv_from_initial_stack): Define.
* nto-tdep.h (nto_read_auxv_from_initial_stack): Declare.