From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65653-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26623 invoked by alias); 25 Jul 2009 22:07:13 -0000
Received: (qmail 26611 invoked by uid 22791); 25 Jul 2009 22:07:13 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 25 Jul 2009 22:07:04 +0000
Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) 	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id EC5444; 	Sat, 25 Jul 2009 15:07:00 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by jupiter.vmware.com (Postfix) with ESMTP id E1B94DC0F1; 	Sat, 25 Jul 2009 15:07:00 -0700 (PDT)
Message-ID: <4A6B806D.6030103@vmware.com>
Date: Sat, 25 Jul 2009 22:20:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: Mark Kettenis <mark.kettenis@xs4all.nl>,   gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA/RFC Prec] Add Linux AMD64 process record support second  	version, (instruction set support) 1/3
References: <daef60380907061937n26fb7503yb30a17273c668a85@mail.gmail.com> 	<4A5A810B.7080603@vmware.com> <daef60380907170146u7c1dd6d4yb4e5e99a9add4634@mail.gmail.com> 	<4A610EE8.1090904@vmware.com> <daef60380907191016u67d99861oeac6e5b449b512af@mail.gmail.com>
In-Reply-To: <daef60380907191016u67d99861oeac6e5b449b512af@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00632.txt.bz2

Hui Zhu wrote:
> On Sat, Jul 18, 2009 at 07:53, Michael Snyder<msnyder@vmware.com> wrote:

>> Mark Kettenis should approve it, though.
>>
> 
> 
> Thanks Michael.
> 
> I update the patches according to your mail except changelog.  Because
> It sames that we just add * at the begin of the function name.
> 
> Please help me review it.
> 
> Thanks,
> Hui
> 
> 2009-07-20  Hui Zhu  <teawater@gmail.com>
> 
>         Add AMD64 process record instruction set support.
> 
>         * i386-tdep.h (gdbarch_tdep): Add record_regmap for registers
>         because the AMD64's registers order in GDB is not same with
>         I386 instructions.
>         Add i386_syscall_record to be the syscall function handle
>         interface.
>         (record_i386_regnum): Number for record_regmap.
>         * i386-tdep.c (OT_QUAD): For 64 bits.
>         (i386_record_s): Add rex_x, rex_b, rip_offset and
>         popl_esp_hack for AMD64 instruction set. And regmap for
>         record_regmap.
>         (i386_record_lea_modrm_addr): Support AMD64 instruction set
>         64 bits lea.
>         (i386_record_lea_modrm): Ditto.
>         (i386_record_push): New function.  Record the execution log
>         of push.
>         (I386_RECORD_ARCH_LIST_ADD_REG): New macro to record the
>         register.
>         (i386_process_record): Support AMD64 instruction set.
>         amd64-tdep.c (amd64_record_regmap): For record_regmap.
>         (amd64_init_abi): Set amd64_record_regmap to record_regmap.

	* amd64-tdep.c (...):

Except for this small nit with the changelog,
I have no further issues with this patch.
Thanks for all your revisions (and your hard work)!

Mark?  You have the final say...