Re: [patch] nto-procfs.c: Add to_xfer_partial

Pedro Alves
2009-07-24T13:00:38Z

On Tuesday 07 July 2009 17:22:39, Aleksandar Ristovski wrote:

> Index: gdb/nto-procfs.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/nto-procfs.c,v
> retrieving revision 1.47
> diff -u -p -r1.47 nto-procfs.c
> --- gdb/nto-procfs.c    2 Jul 2009 17:12:25 -0000       1.47
> +++ gdb/nto-procfs.c    7 Jul 2009 16:16:23 -0000
> @@ -774,6 +774,39 @@ procfs_xfer_memory (CORE_ADDR memaddr, g
>    return (nbytes);
>  }
>
> +static LONGEST
> +procfs_xfer_partial (struct target_ops *ops, enum target_object object,
> +                    const char *annex, gdb_byte *readbuf,
> +                    const gdb_byte *writebuf, ULONGEST offset, LONGEST len)
> +{
...
> +  if (ops->beneath && ops->beneath->to_xfer_partial)
> +    return ops->beneath->to_xfer_partial (ops, object, annex, readbuf,
> +                                         writebuf, offset, len);

(( Note: It isn't correct to defer to the target beneath for
TARGET_OBJECT_MEMORY (and similars) objects, but, I see that nto-procfs.c
is still implementing deprecated_xfer_memory. ))

> +  return -1;
> +}
> +
>  /* Take a program previously attached to and detaches it.
>     The program resumes execution and will no longer stop
>     on signals, etc.  We'd better not have left any breakpoints
> @@ -1307,6 +1340,7 @@ init_procfs_ops (void)
>    procfs_ops.to_store_registers = procfs_store_registers;
>    procfs_ops.to_prepare_to_store = procfs_prepare_to_store;
>    procfs_ops.deprecated_xfer_memory = procfs_xfer_memory;
> +  procfs_ops.to_xfer_partial = procfs_xfer_partial;
>    procfs_ops.to_files_info = procfs_files_info;
>    procfs_ops.to_insert_breakpoint = procfs_insert_breakpoint;
>    procfs_ops.to_remove_breakpoint = procfs_remove_breakpoint;

> Index: gdb/nto-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/nto-tdep.c,v
> retrieving revision 1.34
> diff -u -p -r1.34 nto-tdep.c
> --- gdb/nto-tdep.c      12 Jun 2009 02:32:10 -0000      1.34
> +++ gdb/nto-tdep.c      7 Jul 2009 16:16:23 -0000
> @@ -364,6 +364,70 @@ nto_initialize_signals (void)
>  #endif
>  }
>
> +LONGEST
> +nto_read_auxv_from_initial_stack (CORE_ADDR initial_stack, gdb_byte *readbuf,
> +                                 LONGEST len)
> +{
> +  gdb_byte targ32[4]; /* For 32 bit target values.  */
> +  CORE_ADDR data_ofs = 0;
> +  ULONGEST anint;
> +  LONGEST len_read = 0;
> +  gdb_byte *buff;
> +  /* For 32-bit architecture, size of auxv_t is 8 bytes.  */
> +  const unsigned int sizeof_auxv_t = 8;

NTO doesn't support any 64-bit architecture?

> +  enum bfd_endian byte_order;
> +
> +  /* Skip over argc, argv and envp... (see comment in ldd.c)  */
> +  if (target_read_memory (initial_stack + data_ofs, targ32, sizeof (targ32))
> +      != 0)
> +    return 0;

Can you paste here that ldd.c comment too? You had pasted it in the
equivalent gdbserver bit.

Otherwise, looks fine to me.

--
Pedro Alves