From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13888 invoked by alias); 15 Jul 2009 01:21:21 -0000 Received: (qmail 13879 invoked by uid 22791); 15 Jul 2009 01:21:21 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_43 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jul 2009 01:21:13 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id D807B13017; Tue, 14 Jul 2009 18:21:11 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id CDF05C9FAA; Tue, 14 Jul 2009 18:21:11 -0700 (PDT) Message-ID: <4A5D2DE8.3010605@vmware.com> Date: Wed, 15 Jul 2009 08:33:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" , Hui Zhu Subject: [patch] reverse-finish.exp Content-Type: multipart/mixed; boundary="------------080506080100040708000903" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00389.txt.bz2 This is a multi-part message in MIME format. --------------080506080100040708000903 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 265 I goofed when I wrote this test. I was thinking that reverse-finish would always bring us to the beginning of the calling source line, but it won't. Just like forward finish, it may stop in the middle of the line. Hui, this should make this test pass on amd64. --------------080506080100040708000903 Content-Type: text/plain; name="finish.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="finish.txt" Content-length: 3002 2009-07-14 Michael Snyder * gdb.reverse/finish-reverse.exp: Do not expect reverse-finish to bring gdb to the beginning of the calling line. Index: gdb.reverse/finish-reverse.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.reverse/finish-reverse.exp,v retrieving revision 1.1 diff -u -p -r1.1 finish-reverse.exp --- gdb.reverse/finish-reverse.exp 27 Jun 2009 18:49:20 -0000 1.1 +++ gdb.reverse/finish-reverse.exp 15 Jul 2009 01:17:58 -0000 @@ -27,34 +27,6 @@ if { [prepare_for_testing $testfile.exp return -1 } -proc test_start_of_line { line_text test_msg } { - global gdb_prompt - global decimal - global hex - - send_gdb "info line\n" - gdb_expect { - -re "Line $decimal of .* starts at address ($hex) .*$gdb_prompt $" { - set line_begin $expect_out(1,string) - } - default { - fail "Get line address in test_start_of_line" - } - } - send_gdb "info reg pc\n" - gdb_expect { - -re ".*: ($hex)\r\n*$gdb_prompt $" { - set stop_pc $expect_out(1,string) - } - default { - fail"Get stop pc in test_start_of_line" - } - } - gdb_test "print $line_begin == $stop_pc" \ - " = 1\[\r\n\]*" \ - "test_start_of_line, $test_msg" -} - runto main if [target_info exists gdb,use_precord] { @@ -193,7 +165,7 @@ gdb_continue_to_breakpoint "long_long_fu set test_msg "reverse finish from long_long_func" gdb_test_multiple "finish" "$test_msg" { -re ".* long_checkpoint.*$gdb_prompt $" { - test_start_of_line "long_checkpoint" "$test_msg" + pass "$test_msg" } } @@ -205,7 +177,7 @@ gdb_continue_to_breakpoint "long_func" " set test_msg "reverse finish from long_func" gdb_test_multiple "finish" "$test_msg" { -re ".* int_checkpoint.*$gdb_prompt $" { - test_start_of_line "int_checkpoint" "$test_msg" + pass "$test_msg" } } @@ -217,7 +189,7 @@ gdb_continue_to_breakpoint "int_func" ". set test_msg "reverse finish from int_func" gdb_test_multiple "finish" "$test_msg" { -re ".* short_checkpoint.*$gdb_prompt $" { - test_start_of_line "short_checkpoint" "$test_msg" + pass "$test_msg" } } @@ -229,7 +201,7 @@ gdb_continue_to_breakpoint "short_func" set test_msg "reverse finish from short_func" gdb_test_multiple "finish" "$test_msg" { -re ".* char_checkpoint.*$gdb_prompt $" { - test_start_of_line "char_checkpoint" "$test_msg" + pass "$test_msg" } } @@ -241,7 +213,7 @@ gdb_continue_to_breakpoint "char_func" " set test_msg "reverse finish from char_func" gdb_test_multiple "finish" "$test_msg" { -re ".* void_checkpoint.*$gdb_prompt $" { - test_start_of_line "void_checkpoint" "$test_msg" + pass "$test_msg" } } @@ -253,7 +225,7 @@ gdb_continue_to_breakpoint "void_func" " set test_msg "reverse finish from void_func" gdb_test_multiple "finish" "$test_msg" { -re ".* call to void_func.*$gdb_prompt $" { - test_start_of_line "call to void_func" "$test_msg" + pass "$test_msg" } } --------------080506080100040708000903--