From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10067 invoked by alias); 15 Jul 2009 01:12:39 -0000 Received: (qmail 10059 invoked by uid 22791); 15 Jul 2009 01:12:38 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jul 2009 01:12:31 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id ACAE311007; Tue, 14 Jul 2009 18:12:26 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost2.vmware.com (Postfix) with ESMTP id 8A7AC8EBF4; Tue, 14 Jul 2009 18:12:26 -0700 (PDT) Message-ID: <4A5D2BDA.3000508@vmware.com> Date: Wed, 15 Jul 2009 01:21:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Mark Kettenis CC: "gdb-patches@sourceware.org" , "drow@false.org" Subject: Re: [RFA] testsuite tweak for gdb.arch/i386-signal.c References: <4A5B97CB.2040109@vmware.com> <200907132032.n6DKWNXe032230@brahms.sibelius.xs4all.nl> In-Reply-To: <200907132032.n6DKWNXe032230@brahms.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00387.txt.bz2 Mark Kettenis wrote: >> Date: Mon, 13 Jul 2009 13:23:39 -0700 >> From: Michael Snyder >> >> Index: gdb.arch/i386-signal.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-signal.c,v >> retrieving revision 1.4 >> diff -u -p -r1.4 i386-signal.c >> --- gdb.arch/i386-signal.c 3 Jan 2009 05:58:03 -0000 1.4 >> +++ gdb.arch/i386-signal.c 13 Jul 2009 20:22:52 -0000 >> @@ -37,6 +37,10 @@ main (void) >> The default CIE created by gas suffices to unwind from an empty >> function. */ >> >> +/* Note: to make sure that the Dwarf unwinder gets to handle >> + the frame, we add an extra 'nop' after the label. Otherwise, >> + the new epilogue unwinder will see the 'ret' and grab the frame. */ > > Hmm, at some point in the future this epilogue unwinder will no longer > be new. Checked in with the word "new" removed.