From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13874 invoked by alias); 13 Jul 2009 20:28:24 -0000 Received: (qmail 13865 invoked by uid 22791); 13 Jul 2009 20:28:23 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Jul 2009 20:28:15 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id AB41537007; Mon, 13 Jul 2009 13:28:13 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by jupiter.vmware.com (Postfix) with ESMTP id 9E774DC4D5; Mon, 13 Jul 2009 13:28:13 -0700 (PDT) Message-ID: <4A5B97CB.2040109@vmware.com> Date: Mon, 13 Jul 2009 22:14:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" , drow@false.org, mark.kettenis@xs4all.nl Subject: [RFA] testsuite tweak for gdb.arch/i386-signal.c Content-Type: multipart/mixed; boundary="------------090705070802000408070607" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00374.txt.bz2 This is a multi-part message in MIME format. --------------090705070802000408070607 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 134 Tweak this test so that the new i386 epilogue unwinder won't be tripped up by a function consisting of the single instruction 'ret'. --------------090705070802000408070607 Content-Type: text/plain; name="nop.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="nop.txt" Content-length: 1015 2009-07-13 Michael Snyder * gdb.arch/i386-signal.c (sigframe): Add a nop to avoid confusing the i386 epilogue unwinder. Index: gdb.arch/i386-signal.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-signal.c,v retrieving revision 1.4 diff -u -p -r1.4 i386-signal.c --- gdb.arch/i386-signal.c 3 Jan 2009 05:58:03 -0000 1.4 +++ gdb.arch/i386-signal.c 13 Jul 2009 20:22:52 -0000 @@ -37,6 +37,10 @@ main (void) The default CIE created by gas suffices to unwind from an empty function. */ +/* Note: to make sure that the Dwarf unwinder gets to handle + the frame, we add an extra 'nop' after the label. Otherwise, + the new epilogue unwinder will see the 'ret' and grab the frame. */ + asm(".text\n" " .align 8\n" " .globl setup\n" @@ -49,5 +53,6 @@ asm(".text\n" " nop\n" " .globl sigframe\n" "sigframe:\n" + " nop\n" " ret\n" " .cfi_endproc"); --------------090705070802000408070607--