From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26100 invoked by alias); 13 Jul 2009 00:52:28 -0000 Received: (qmail 26092 invoked by uid 22791); 13 Jul 2009 00:52:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Jul 2009 00:52:19 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 1268D4003; Sun, 12 Jul 2009 17:52:18 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by jupiter.vmware.com (Postfix) with ESMTP id 034ECDC34E; Sun, 12 Jul 2009 17:52:18 -0700 (PDT) Message-ID: <4A5A8438.6030005@vmware.com> Date: Mon, 13 Jul 2009 03:32:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml Subject: Re: [RFA/RFC Prec] Add Linux AMD64 process record support second version, (AMD64 Linux system call support) 3/3 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00353.txt.bz2 Hui Zhu wrote: > Add prec support like i386-linux-tdep.c. > > 2009-07-07 Hui Zhu > > Add Linux AMD64 process record support. > > * amd64-linux-tdep.c (amd64_linux_record_tdep): New variable. > This struct has the argument for the function > "record_linux_system_call". > (amd64_linux_syscall_record): New function. Parse the > system call instruction and call function > "record_linux_system_call" to record execute log. > (i386_linux_init_abi): Initialize "amd64_linux_record_tdep". > Set "amd64_linux_syscall_record" to "i386_syscall_record". Once again, just a preliminary review. Same comments about space-after-cast etc. > + /* Covent tmpulongest to number in record_linux_system_call. */ "Convert", maybe? > + /* Initialize the amd64_linux_record_tdep. */ > + /* These values are the size of the type that will be used in a system > + call. They are obtained from Linux Kernel source. */ > + amd64_linux_record_tdep.size_pointer = 8; Can you use gdbarch_ptr_bit (gdbarch)? > + amd64_linux_record_tdep.size_int = 4; > + amd64_linux_record_tdep.size_long = 8; > + amd64_linux_record_tdep.size_ulong = 8; And again, aren't these sizes also in the gdbarch? Do we need to duplicate them here?