From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1246 invoked by alias); 12 Jul 2009 17:47:27 -0000 Received: (qmail 1237 invoked by uid 22791); 12 Jul 2009 17:47:26 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Jul 2009 17:47:18 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 27F8813028; Sun, 12 Jul 2009 10:47:17 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost2.vmware.com (Postfix) with ESMTP id E6AC28E9C8; Sun, 12 Jul 2009 10:47:16 -0700 (PDT) Message-ID: <4A5A209E.5050202@vmware.com> Date: Sun, 12 Jul 2009 17:53:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Mark Kettenis CC: "gdb-patches@sourceware.org" , "drow@false.org" , "teawater@gmail.com" Subject: Re: [RFA] epilogue unwinder for i386 (reverse 1/2) References: <4A4EA0F7.1040004@vmware.com> <4A4EA3B3.9030107@vmware.com> <200907051235.n65CZhDb024857@brahms.sibelius.xs4all.nl> <4A511332.2000607@vmware.com> <4A58D5D7.9070504@vmware.com> <200907121112.n6CBCG1x032181@brahms.sibelius.xs4all.nl> In-Reply-To: <200907121112.n6CBCG1x032181@brahms.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00346.txt.bz2 Mark Kettenis wrote: >> Date: Sat, 11 Jul 2009 11:11:35 -0700 >> From: Michael Snyder >> >> Mark, Daniel, is this OK now? > > Not quite. You fullfilled my request for using lower case for the > instruction mneonics, only to add more uppercase ones in the new > comment :(. Oh, anc for consistency please use %reg syntax instead of > REG. Sorry! Fixed. > You know what; go ahead and commit this; I'll clean up afterwards. That's great of you. Hope I've already taken care of it. Committing. Daniel, a heads-up -- this seems to break your test "i386-signal.exp".