Daniel Jacobowitz wrote:
> On Mon, Jul 06, 2009 at 12:33:51PM -0400, Aleksandar Ristovski wrote:
>> ping?
>>
>> Note: new patch attached taking into account current_gdbarch removal.
> 
> These look OK to me.  You might want to use the same style used for
> other settings though: "auto (currently spe)".
> 

Changed accordingly:

$ ./gdb
GNU gdb (GDB) 6.8.50.20090706-cvs
(gdb) show powerpc vector-abi
The current vector ABI is "auto" (currently "generic").
(gdb) set powerpc vector-abi spe
(gdb) show powerpc vector-abi
The current vector ABI is "spe"
(gdb) file 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE
Reading symbols from 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE...done.
(gdb) show powerpc vector-abi
The current vector ABI is "spe"
(gdb) file 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe
Load new symbol table from 
"/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe"? 
(y or n) y
Reading symbols from 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe...done.
(gdb) show powerpc vector-abi
The current vector ABI is "spe"
                           ^^^^^^
                   because we set it explicitly.
(gdb) q


Now auto selection:
$ ./gdb
...
(gdb) show powerpc vector-abi
The current vector ABI is "auto" (currently "generic").
(gdb) file 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE
Reading symbols from 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gSPE...done.
(gdb) show powerpc vector-abi
The current vector ABI is "auto" (currently "spe").
(gdb) file 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe
Load new symbol table from 
"/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe"? 
(y or n) y
Reading symbols from 
/home/src/testcases/ppcspetest/nto/ppc/o-be-g/ppcspetest_gnospe...done.
(gdb) show powerpc vector-abi
The current vector ABI is "auto" (currently "generic").
(gdb)



Note that I made one change to my original proposal, namely 
in rs6000_gdbarch_init, if vector_abi is  POWERPC_VEC_SPE we 
assume arch bfd_arch_powerpc since if we are just changing 
the vector-abi without a file, it would be unable to match 
target description.


-- 
Aleksandar Ristovski
QNX Software Systems


ChangeLog for rs6000-tdep-mach_type_from_gnu_obj_attr:

* rs6000-tdep.c (rs6000_gdbarch_init): Rearange the code to use
..gnu.attributes to see if this is a e500 binary (with SPE APU).


ChangeLog for rs6000-tdep-show_vector_abi:

* rs6000-tdep.c (powerpc_show_vector_abi): New function.
(_initialize_rs6000_tdep): Use powerpc_show_vector_abi.