From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25526 invoked by alias); 29 Jun 2009 20:29:52 -0000 Received: (qmail 25518 invoked by uid 22791); 29 Jun 2009 20:29:51 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Jun 2009 20:29:46 +0000 Received: (qmail 28229 invoked from network); 29 Jun 2009 20:29:44 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Jun 2009 20:29:44 -0000 Message-ID: <4A492432.8010600@codesourcery.com> Date: Mon, 29 Jun 2009 20:29:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605) MIME-Version: 1.0 To: Eli Zaretskii CC: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [PATCH] Conditional tracepoints References: <4A45AE9B.9020400@codesourcery.com> <83fxdlzvin.fsf@gnu.org> In-Reply-To: <83fxdlzvin.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00847.txt.bz2 Eli Zaretskii wrote: >> Date: Fri, 26 Jun 2009 22:31:07 -0700 >> From: Stan Shebs >> >> This patch adds conditional tracepoints. >> > > Thanks. > > I think we need a NEWS entry for this. > OK, good idea. >> + programming language (@pxref{Expressions, ,Expressions}). A >> + tracepoint with a condition evaluates the expression each time your >> + program reaches it, and data collection happens only if the condition >> + is @emph{true}. >> > > Not sure why you use the @emph markup here. I think the text is okay > without any markup at all. > It's been several months since I wrote it, and now I don't remember either. :-) > >> @table @code >> @kindex maint agent >> + @kindex maint agent-eval >> @item maint agent @var{expression} >> + @itemx maint agent-eval @var{expression} >> Translate the given @var{expression} into remote agent bytecodes. >> This command is useful for debugging the Agent Expression mechanism >> ! (@pxref{Agent Expressions}). The @samp{agent} version produces an >> ! expression useful for data collection, such as by tracepoints, while >> ! @samp{maint agent-eval} produces an expression that evaluates directly >> ! to a result. >> > > I must admit that I don't understand the description you added. What > does "expression useful for data collection" mean, and how is it > different from "expression that evaluates directly to a result"? > Expressions compiled for tracing have bytecodes that cause saving of the blocks of memory etc that would be needed back on the host to evaluate the expression at some later date. It occurs to me that the Agent Expressions section should say a little more about the two kind of expressions. >> + @item ConditionalTracepoints >> + The remote stub accepts and tests conditional expressions defined for >> + tracepoints (@pxref{Tracepoint Conditions}). >> > > Don't you mean "accepts and supports" or "accepts and implements"? > "support" and "implement" seemed overused. :-) Stan