From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29811 invoked by alias); 24 Jun 2009 19:04:58 -0000 Received: (qmail 29788 invoked by uid 22791); 24 Jun 2009 19:04:50 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from qnxmail.qnx.com (HELO qnxmail.qnx.com) (209.226.137.76) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Jun 2009 19:04:44 +0000 Received: from Nebula.ott.qnx.com (nebula.ott.qnx.com [10.42.3.30]) by hub.ott.qnx.com (8.9.3/8.9.3) with ESMTP id PAA10518; Wed, 24 Jun 2009 15:04:36 -0400 Received: from [127.0.0.1] ([10.42.100.129]) by Nebula.ott.qnx.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 24 Jun 2009 15:04:42 -0400 Message-ID: <4A4278C9.8050609@qnx.com> Date: Wed, 24 Jun 2009 19:04:00 -0000 From: Aleksandar Ristovski User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: Doug Evans , Pedro Alves Subject: Re: [patch] gdbserver: Add support for Z0/Z1 packets References: <200906222346.54263.pedro@codesourcery.com> <4A40F226.4080909@qnx.com> <200906231700.12402.pedro@codesourcery.com> <4A427584.2090908@qnx.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00654.txt.bz2 Doug Evans wrote: > On Wed, Jun 24, 2009 at 11:50 AM, Aleksandar > Ristovski wrote: >> I did not do any renaming - I think it is not terribly confusing since both >> in target.h comment and server.c 'Z' case it is made very clear that it >> handles both breakpoints and watchpoints (i.e. I don't find it any clearer >> if it was called "insert_point"... it would still require reading the >> comment in target.h) > > fwiw, I think the naming is important. People come at the source from > various angles, starting points, and contexts. I can imagine someone > getting tripped up (i.e. spending time doing something that they > otherwise wouldn't have) by reading "insert_watchpoint" and not > knowing it also applied to breakpoints. Good names are important. (or > at least not obviously problematic names; picking good names is > sometimes hard, for me anyway). > > My $0.02. > Never ment to say it isn't important, just that "insert_point" didn't look more clear to me. But that's just me, of course. -- Aleksandar Ristovski QNX Software Systems