From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 668 invoked by alias); 15 Jun 2009 18:04:14 -0000 Received: (qmail 657 invoked by uid 22791); 15 Jun 2009 18:04:13 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Jun 2009 18:04:05 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id ACE2BA016; Mon, 15 Jun 2009 11:04:03 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost2.vmware.com (Postfix) with ESMTP id 927AE8E978; Mon, 15 Jun 2009 11:04:03 -0700 (PDT) Message-ID: <4A368D36.2080102@vmware.com> Date: Mon, 15 Jun 2009 18:04:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Marc Khouzam CC: Hui Zhu , "gdb-patches@sourceware.org" Subject: Re: [RFA] Patch to fix "reverse-next" command error References: <4A35B5CD.1030004@vmware.com> <6D19CA8D71C89C43A057926FE0D4ADAA079760F1@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA079760F1@ecamlmw720.eamcs.ericsson.se> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00396.txt.bz2 Marc Khouzam wrote: >> -----Original Message----- >> From: gdb-patches-owner@sourceware.org >> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Hui Zhu >> Sent: June-15-09 2:47 AM >> To: Michael Snyder; Marc Khouzam >> Cc: gdb-patches@sourceware.org >> Subject: Re: [RFA] Patch to fix "reverse-next" command error >> >> On Mon, Jun 15, 2009 at 10:45, Michael >> Snyder wrote: >>> Hui Zhu wrote: >>>> Ping. >>> Hui, I rewrote your patch a little bit. I think we can use >>> gdbarch_skip_trampoline_code to detect the fact that we have >>> stepped into a trampoline (ie. "plt"). This is more general. >>> >>> Mark, please tell me if this patch fixes your original problem, >>> and Hui, please tell me if the patch is OK with you. >>> >> This patch is OK with me. > > I also tested this one and it works great for me as well. > > Thanks OK, so sounds like this one can go in as well. Michael