Thank you for reviewing the patch! Joel Brobecker wrote: >> Add support for XMM registers. >> * i386-nto-tdep.c (i386_nto_target): Remove definition. >> (i386nto_regset_id): Add case for SSE register set. >> (i386nto_register_area): Correctly calculate offsets and sizes for all >> supported registers. >> (I386_NTO_SIGCONTEXT_OFFSET): Remove macro definition. >> (i386nto_sigcontext_addr): Use better method of retrieving sigcontext >> pointer. >> (init_i386nto_ops): Remove i386_nto_target. >> (i386nto_init_abi): Remove nto_svr4_so_ops indirection. Properly setup >> tdep params sc_reg_offset and sc_num_regs. Remove nto_svr4_so_ops and >> make changes accordingly. > > I won't pretend I understand everything you do in this patch, but > the pieces that are related to registers and sigcontext seem to be > sensible. > > However, I found a few hunks which I think are not related to XMM > register support, but rather to shared library support... Attached is "clean" XMM support patch. Thanks, -- Aleksandar Ristovski QNX Software Systems ChangeLog: Add support for XMM registers. * i386-nto-tdep.c (i386nto_regset_id): Add case for SSE register set. (i386nto_register_area): Correctly calculate offsets and sizes for all supported registers.