From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12452 invoked by alias); 1 Jun 2009 19:24:44 -0000 Received: (qmail 12444 invoked by uid 22791); 1 Jun 2009 19:24:43 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Jun 2009 19:24:39 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 532EC134B4; Mon, 1 Jun 2009 12:24:38 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost3.vmware.com (Postfix) with ESMTP id 48981CD990; Mon, 1 Jun 2009 12:24:38 -0700 (PDT) Message-ID: <4A242A52.3030802@vmware.com> Date: Mon, 01 Jun 2009 19:24:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" , "vladimir@codesourcery.com" Subject: Re: [PATCH] fix break-always test References: <4A2072C1.9000409@vmware.com> <200905300056.43216.pedro@codesourcery.com> In-Reply-To: <200905300056.43216.pedro@codesourcery.com> Content-Type: multipart/mixed; boundary="------------040703090100050008040707" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00012.txt.bz2 This is a multi-part message in MIME format. --------------040703090100050008040707 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 821 Pedro Alves wrote: > On Saturday 30 May 2009 00:41:53, Michael Snyder wrote: >> "set breakpoint always" does not accept "1", it wants "on". >> > > (gdb) set breakpoint always-inserted 1 > Undefined item: "1". > (gdb) PASS: gdb.base/break-always.exp: set breakpoint always-inserted 1 > > Outch, this used to work, until set breakpoint always-inserted > was made into a three-state. Yikes, this has been broken for months. > My fault, as usual. :-) > >> 2009-05-29 Michael Snyder >> >> * gdb.base/break-always.exp: Change "1" to "on". > > This is certainly OK. > > It would be a nice improvent to make the test confirm that > the mode is in effect, perhaps by just reading back the > setting with "show breakpoint always-inserted". Good idea, implemented and checked in as below. --------------040703090100050008040707 Content-Type: text/plain; name="always.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="always.txt" Content-length: 776 2009-05-29 Michael Snyder * gdb.base/break-always.exp: Change "1" to "on". Add confirmation check. Index: gdb.base/break-always.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break-always.exp,v retrieving revision 1.2 diff -d -u -r1.2 break-always.exp --- gdb.base/break-always.exp 3 Jan 2009 05:58:03 -0000 1.2 +++ gdb.base/break-always.exp 1 Jun 2009 19:18:59 -0000 @@ -21,7 +21,10 @@ set bar_location [gdb_get_line_number "break in bar" break-always.c] -gdb_test "set breakpoint always-inserted 1" "" +gdb_test "set breakpoint always-inserted on" "" + +gdb_test "show breakpoint always-inserted" "mode is on\." \ + "confirm breakpoint always-inserted" runto foo --------------040703090100050008040707--