From: David Daney <ddaney@caviumnetworks.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove unecessary checks for macros in target.h
Date: Fri, 08 May 2009 16:45:00 -0000 [thread overview]
Message-ID: <4A046173.8030704@caviumnetworks.com> (raw)
In-Reply-To: <003301c9cfe3$e7547ed0$b5fd7c70$@u-strasbg.fr>
Pierre Muller wrote:
> target.h header has lots of
>
> #ifndef A_MACRO
> #define A_MACRO default_implementation
> #endif
> constructs.
>
> This patch simply removes all these
> unnecessary checks for macros that are not defined anymore in any
> config file, nor by configure script.
> (Unless the configure scripts might set macros
> without having them inside their sources,
> I checked all those macros by grep).
>
> Is this OK?
>
I don't know if it is OK.
However, I do wonder if it would make sense to remove the macros
altogether, and just push the expansions down into the code. If we
really don't want to be able to switch in different implementations of
these things, what is the point of an added layer of abstraction?
David Daney
next prev parent reply other threads:[~2009-05-08 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 13:50 Pierre Muller
2009-05-08 15:30 ` Joel Brobecker
2009-05-08 16:45 ` David Daney [this message]
2009-05-08 20:32 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A046173.8030704@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox