From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131916-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17151 invoked by alias); 3 Jun 2016 15:45:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 17135 invoked by uid 89); 3 Jun 2016 15:45:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=manages, strikes, sk:server
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 03 Jun 2016 15:45:28 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 8074F4464C;	Fri,  3 Jun 2016 15:45:27 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u53FjQo8014037;	Fri, 3 Jun 2016 11:45:26 -0400
Subject: Re: [PATCH v2] Fix failure to detach if threads exit while detaching on linux
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
References: <bf6cd7bf-4f1a-b5c6-b396-e5ae42ed9c70@redhat.com> <1464965361-25399-1-git-send-email-antoine.tremblay@ericsson.com> <f6d86604-6cf9-3ba4-bec7-958b19e82400@redhat.com> <wwokshwujnjz.fsf@ericsson.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <49f3eb1e-d03d-e434-a831-e40f18f7823c@redhat.com>
Date: Fri, 03 Jun 2016 15:45:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <wwokshwujnjz.fsf@ericsson.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-06/txt/msg00060.txt.bz2

On 06/03/2016 04:32 PM, Antoine Tremblay wrote:
>>> >> +	#Don't try to exit gdbserver see above comment.
>>> >> +	set gdbserver_reconnect_p 1
>> >
>> > I don't understand this one.  It shouldn't be needed.
>> >
> This one is needed since on the teardown of the .exp test gdb_exit is
> called and calls monitor_exit which fails with a timeout this avoids
> this and the original gdb_exit is called.

Then that strikes me as the wrong thing to do.  We should instead
expect that gdbserver exits cleanly, and then clear server_spawn_id.

E.g.:

proc test_server_exit {} {
  global server_spawn_id
  if ![info exists server_spawn_id] {
    return
  }
  
  set test "server exits"
  gdb_expect {
     -i $server_spawn_id
     eof {
        pass $test
	wait -i $server_spawn_id
        unset server_spawn_id
     }
     timeout {
       fail "$test (timeout)"
     }
   }
  }
}

and then:

    -re "Detaching from .*, process $decimal\r\nEnding remote debugging\.\r\n$gdb_prompt $" {
        # This is what you get with "target remote".
        pass $test
        # If testing with gdbserver, make sure it manages to exit.
        test_server_exit
    }

Thanks,
Pedro Alves