From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KPKBBLUCiGeANhAAWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 13:47:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736966837; bh=fY9ajoCGJszUjZZvQ24swDuLH58U1ci7MDegzDXho2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EYYrMROmr2RNzBYgHhX2vpNDwt3PrlR3fVUews1VYp1frSb71netb9avCEFDmrkQU 8RUEZwTheHXYr00D4xjinkGJRE0jiS92ai9rYpbVreFuwHQtXqTeDOC8sBixJbN+m4 FZiciL0F8LvSq6UNlfXWl7CPfb+L77BCL094Vd+c= Received: by simark.ca (Postfix, from userid 112) id 0FB751E100; Wed, 15 Jan 2025 13:47:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=H3dSK7xW; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=cImEPaS/; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C0D21E05C for ; Wed, 15 Jan 2025 13:47:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4906F38515C7 for ; Wed, 15 Jan 2025 18:47:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4906F38515C7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=H3dSK7xW; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=cImEPaS/ Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9236E3851A98 for ; Wed, 15 Jan 2025 18:46:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9236E3851A98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9236E3851A98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736966804; cv=none; b=wpnQIHusxmixZte5C1yw96mOkkgGtFlvAmGa1AwxjnpL25CTHYEh/dtjFYIYEoKYZsuItenzX24N6kxS8QEAdMQrv4PHW5TqWFndvY3RVw3THlKRjVop3ITxXbgYedbOOvKDVkGI6ywOHj2sBvaMR3fli9Zz0eFY0quWiE6/xGk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736966804; c=relaxed/simple; bh=fY9ajoCGJszUjZZvQ24swDuLH58U1ci7MDegzDXho2U=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=YKnKdPWFtd3R6KnpEfYD3k+FRHobXbELCQTbw7rlJbZZtvF6TEzGur1udSalfBVGAd17wagLXd4UgTK/afLvdpSVN9uWtX1UJH+u83QzV3HsudeV/hbXp/PkUvreE32Uu1jowR72onGl1zVljaP/LJBP+rT4earNSBdJnkqo4vQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9236E3851A98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736966803; bh=fY9ajoCGJszUjZZvQ24swDuLH58U1ci7MDegzDXho2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=H3dSK7xWUR/Uc3XU6trXTh4J8nvmxSvMOAnea6dDEqob9r5vvDT0LGAphxQliF2Bu mHmjyyabSo4NHkgTz52SohhxdtPrR6bbnmVMwVe0ViVsNpudfZYbpZXApRU79CVFe8 DUOfxoK4oN8XZe7fBGXyaTuPLMvNxlVswqF71cgk= Received: by simark.ca (Postfix, from userid 112) id ED4951E10A; Wed, 15 Jan 2025 13:46:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736966802; bh=fY9ajoCGJszUjZZvQ24swDuLH58U1ci7MDegzDXho2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cImEPaS/oQy5xxWCjDGKipoQ+2KO/ijuBYOEdz/UyH+shwo1U2w2jy07Hyj2kexdj GBFOHdZgAciOQClI0FBmnPQd+NLyr7sd0mzZQQqO3hQEDem1/0grxvZ43Hk9+pFpJe FR6GGlZSK/zSzEJlOEdfJ+Xm1xTPOanYWptA0X4w= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B275F1E05C; Wed, 15 Jan 2025 13:46:42 -0500 (EST) Message-ID: <49b2c439-b459-480c-9918-64344424c5b6@simark.ca> Date: Wed, 15 Jan 2025 13:46:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map To: Simon Marchi , Lancelot SIX , gdb-patches@sourceware.org Cc: Simon Marchi References: <20250114191818.2393132-1-simon.marchi@polymtl.ca> <20250114191818.2393132-2-simon.marchi@polymtl.ca> <54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca> Content-Language: en-US From: Simon Marchi In-Reply-To: <54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-01-15 13:41, Simon Marchi wrote: > > > On 2025-01-15 05:55, Lancelot SIX wrote: >> >> >> On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote: >>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. >>> >>> >>> From: Simon Marchi >>> >>> Since we have gdb::unordered_map, swap std::unordered_map for that. >>> >> >> Hi, >> >> That looks good to me, thanks. >> >> Since it only touches the amdgpu backend, >> Approved-By: Lancelot Six (amdgpu) > > Thanks, added. > > Is the (amdgpu) some format we use? I haven't seen it used anywhere > else. I don't mind, for instance, Eli could use Approved-By with (doc). Just note that `b4 am` doesn't preserve the parenthesis, so it's not so handy actually. Simon