From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38390 invoked by alias); 3 Jul 2019 16:28:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38381 invoked by uid 89); 3 Jul 2019 16:28:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jul 2019 16:28:49 +0000 Received: by mail-wm1-f65.google.com with SMTP id c6so3098179wml.0 for ; Wed, 03 Jul 2019 09:28:49 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id w6sm3444285wrp.67.2019.07.03.09.28.46 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jul 2019 09:28:47 -0700 (PDT) Subject: Re: [PATCH 5/5] pipe command completer To: Tom Tromey References: <20190627191427.20742-1-palves@redhat.com> <20190627191427.20742-6-palves@redhat.com> <87sgrtzqo1.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <49a5e085-6bb9-049f-ec33-5ccac11e9301@redhat.com> Date: Wed, 03 Jul 2019 16:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87sgrtzqo1.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00072.txt.bz2 On 6/28/19 4:16 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This commit adds a completer for the "pipe" command. It can complete > Pedro> "pipe"'s options, and the specified GDB command. > > Pedro> To make the completer aware of the "-d" option, this converts the > Pedro> option processing to use gdb::option. > > Thank you for doing this. > > Pedro> gdb/ChangeLog: > Pedro> yyyy-mm-dd Pedro Alves > > Pedro> * cli/cli-cmds.c (struct pipe_cmd_opts): New. > Pedro> (pipe_cmd_option_defs): New. > > BTW this is PR cli/24732. Thanks, I added that to the ChangeLogs and pushed this in. Thanks, Pedro Alves