From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25847 invoked by alias); 24 Apr 2009 17:54:09 -0000 Received: (qmail 25839 invoked by uid 22791); 24 Apr 2009 17:54:08 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Apr 2009 17:54:03 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3OHs2d4026154 for ; Fri, 24 Apr 2009 13:54:02 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3OHs10L022234; Fri, 24 Apr 2009 13:54:01 -0400 Received: from lindt.uglyboxes.com (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3OHrv0j023599; Fri, 24 Apr 2009 13:53:59 -0400 Message-ID: <49F1FCB5.3080404@redhat.com> Date: Fri, 24 Apr 2009 17:54:00 -0000 From: Keith Seitz User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: tromey@redhat.com CC: gdb-patches@sourceware.org Subject: Re: [RFC] Special casing dtors? References: <49CAB139.8010100@redhat.com> <200903301658.16807.pedro@codesourcery.com> <49D3FCC9.7090505@redhat.com> <200904072154.45602.pedro@codesourcery.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------060804090203090704000902" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00697.txt.bz2 This is a multi-part message in MIME format. --------------060804090203090704000902 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 453 Tom Tromey wrote: > I re-read this whole thread this evening, and as far as I can tell, > the original cleanup patch is ok. Early in the thread, Keith said > he'd send a new one that also removed get_destructor_fn_field. > Keith, could you do that? I've attached it. Keith ChangeLog 2009-04-24 Keith Seitz * gdbtypes.h (get_destructor_fn_field): Remove. No longer needed. * gdbtypes.c (get_destructor_fn_field): Likewise. --------------060804090203090704000902 Content-Type: text/plain; name="remove-get_dtor_fn_field.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="remove-get_dtor_fn_field.patch" Content-length: 1620 Index: gdbtypes.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtypes.c,v retrieving revision 1.162 diff -u -p -r1.162 gdbtypes.c --- gdbtypes.c 10 Apr 2009 03:36:32 -0000 1.162 +++ gdbtypes.c 24 Apr 2009 17:50:53 -0000 @@ -1334,34 +1334,6 @@ get_vptr_fieldno (struct type *type, str } } -/* Find the method and field indices for the destructor in class type T. - Return 1 if the destructor was found, otherwise, return 0. */ - -int -get_destructor_fn_field (struct type *t, - int *method_indexp, - int *field_indexp) -{ - int i; - - for (i = 0; i < TYPE_NFN_FIELDS (t); i++) - { - int j; - struct fn_field *f = TYPE_FN_FIELDLIST1 (t, i); - - for (j = 0; j < TYPE_FN_FIELDLIST_LENGTH (t, i); j++) - { - if (is_destructor_name (TYPE_FN_FIELD_PHYSNAME (f, j)) != 0) - { - *method_indexp = i; - *field_indexp = j; - return 1; - } - } - } - return 0; -} - static void stub_noname_complaint (void) { Index: gdbtypes.h =================================================================== RCS file: /cvs/src/src/gdb/gdbtypes.h,v retrieving revision 1.100 diff -u -p -r1.100 gdbtypes.h --- gdbtypes.h 26 Mar 2009 01:27:45 -0000 1.100 +++ gdbtypes.h 24 Apr 2009 17:50:53 -0000 @@ -1201,8 +1201,6 @@ extern struct type *lookup_template_type extern int get_vptr_fieldno (struct type *, struct type **); -extern int get_destructor_fn_field (struct type *, int *, int *); - extern int get_discrete_bounds (struct type *, LONGEST *, LONGEST *); extern int is_ancestor (struct type *, struct type *); --------------060804090203090704000902--