Pedro Alves wrote:
> Thanks for the update.
> 
> On Thursday 16 April 2009 18:08:07, David Daney wrote:
>>>> +    printf_unfiltered (" (addr=%lx, len=%d, type=%s)",
>>>> +                      /* This code is for mips, so casting CORE_ADDR
>>>> +                         to unsigned long should be okay.  */
>>>> +                      (unsigned long)addr, len,
>>> Why bother to explain that instead of using `paddr'?  If there's
>>> a reason, then it would be nice if it was spelled out in the
>>> comment.
>> Comment deleted, and types casted to (unsigned long long).
> 
> Sorry to insist on a debug printf..., but that doesn't explain anything.
> This even looks more misterious.  If this is an address, why the cast
> instead of paddr? -- you use paddr just a bit below.  Is this because addr
> isn't really an address?
> 

You are right.  Using paddr() is the correct thing to do here.  Now fixed.

Coupled with the new infrun.c patch:

http://sourceware.org/ml/gdb-patches/2009-04/msg00529.html

I now have no regressions in the gdb testsuite for 
mips64-unknown-linux-gnu with this patch.

OK to commit?