From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4539 invoked by alias); 18 Apr 2009 07:58:57 -0000 Received: (qmail 4529 invoked by uid 22791); 18 Apr 2009 07:58:56 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from hq2.tensilica.com (HELO maia.hq.tensilica.com) (65.205.227.30) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Apr 2009 07:58:51 +0000 Received: from [172.16.150.11] (nose.hq.tensilica.com [172.16.150.11]) (authenticated bits=0) by maia.hq.tensilica.com (8.13.1/8.13.1) with ESMTP id n3I7wIZG004141; Sat, 18 Apr 2009 00:58:18 -0700 Message-ID: <49E98819.7020706@tensilica.com> Date: Sat, 18 Apr 2009 07:58:00 -0000 From: Ross Morley User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040805 Netscape/7.2 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org, maxim@tensilica.com Subject: Re: [PATCH] Program Breakpoints References: <49E92DCB.4000007@tensilica.com> <8363h2jxcw.fsf@gnu.org> In-Reply-To: <8363h2jxcw.fsf@gnu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00479.txt.bz2 Thanks Eli for your valuable comments. I did indeed miss a bunch of "GDB"s, and double periods after sentences. More in-line... Eli Zaretskii wrote: >>Date: Fri, 17 Apr 2009 18:32:59 -0700 >>From: Ross Morley >>CC: Maxim Grigoriev >> >>The user manual has been updated. I will update the internals >>manual after this patch has been (possibly changed and) accepted. >> >> > >Thank you. I have a few comments for the documentation patch: > > > >>+Some programs may contain embedded break or trap instructions that are >>+unknown to GDB. These are called @dfn{program breakpoints} because they >> >> > ^^^ >"@value{GDBN}". > > > >>+belong to the program itself. If encountered, a target may stop execution >>+and report this to GDB along with how much to increment the PC to step >>+over it (a target is not required to do this). >> >> > >Please don't talk about a "target" in the user's manual: this >terminology is unknown to them. Please talk about the "inferior" or >the "program being debugged". > > You're quite right that I should discuss the target less in the user manual and more in in the internals manual (which I intend to update once this patch has been reviewed and any changes are made). However I'm quite used to seeing the term "target" in the user manual, so am a bit confused on that. I did wish to convey that not all targets (inferiors) will support this feature (perhaps I should just omit the parenthetical part above). Note that in the remote stop-reply section the term "target" is used this way in several places. I will incorparate all of your feedback. Thanks, Ross > > >>+@item program-breakpoint >>+A program breakpoint (trap instruction unknown to GDB) was reached. >> >> > ^^^ >"@value{GDBN}" > > > >>@@ -26723,6 +26731,12 @@ >> @value{GDBN} should use @samp{qXfer:libraries:read} to fetch a new >> list of loaded libraries. @var{r} is ignored. >> >>+@item trap >>+The packet indicates that a target-specific break or trap instruction >>+was hit. @var{r} is the size of the instruction if the PC is pointing >>+to it, else 0 (for example if the hardware already incremented the PC). >>+@var{r} is ignored if the instruction was planted by @value{GDBN}. >>+ >> The packet indicates that the target cannot continue replaying >> >> > >Something strange happened with this hunk. In the current CVS, the >manual in this part looks like this: > > @cindex shared library events, remote reply > @item library > The packet indicates that the loaded libraries have changed. > @value{GDBN} should use @samp{qXfer:libraries:read} to fetch a new > list of loaded libraries. @var{r} is ignored. > > @cindex replay log events, remote reply > @item replaylog > The packet indicates that the target cannot continue replaying > logged execution events, because it has reached the end (or the > beginning when executing backward) of the log. The value of @var{r} > will be either @samp{begin} or @samp{end}. @xref{Reverse Execution}, > for more information. > >So it seems to me that you are plugging your part in the middle of >another @item, but then where's the "@item replaylog" line and the one >preceding it, with @cindex"? What am I missing? > >Finally, please make sure every period that ends a sentence has 2 >spaces, not 1, after it. > > > >>--- gdb/NEWS 31 Mar 2009 20:21:06 -0000 1.305 >>+++ gdb/NEWS 17 Apr 2009 18:55:25 -0000 >>@@ -3,6 +3,10 @@ >> >> *** Changes since GDB 6.8 >> >>+* GDB now supports handling (embedded) program break or trap instructions >>+that are unknown to GDB. These are called program breakpoints because they >>+belong to the program itself. >> >> > >This is good, but I suggest to add a sentence telling how would GDB >manifest these program breakpoints. Also, "program breakpoints" >should be in quotes, as you are introducing a new term. > >Thanks. > > >