From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3169 invoked by alias); 27 Mar 2009 02:35:21 -0000 Received: (qmail 3160 invoked by uid 22791); 27 Mar 2009 02:35:20 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Mar 2009 02:35:15 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2R2ZD4B001309 for ; Thu, 26 Mar 2009 22:35:13 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2R2Z6gb023894 for ; Thu, 26 Mar 2009 22:35:06 -0400 Received: from lindt.uglyboxes.com (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2R2ZAgL001928 for ; Thu, 26 Mar 2009 22:35:12 -0400 Message-ID: <49CC3B5D.3060706@redhat.com> Date: Fri, 27 Mar 2009 08:07:00 -0000 From: Keith Seitz User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFC] Special casing dtors? References: <49CAB139.8010100@redhat.com> <20090327022150.GC29050@caradoc.them.org> In-Reply-To: <20090327022150.GC29050@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00611.txt.bz2 Daniel Jacobowitz wrote: > I remember, about five years ago, doing some serious surgery on the > way the stabs reader reported constructors and destructors. If I had > to guess, I'd say this code was needed before that and/or for GCC 2.x. > But 2.x is pretty scarce on the ground nowadays anyway. Either that, > or something for HP aCC. Eeew... I didn't even think of other compilers and other debug formats. I will do what I can to test on some other platforms, but I hope some kind soul(s) out there will help me/us out by checking some environments to which I do not have access (anything non-GNU/Linux & cygwin). [Pretty please?] > Anyway, good riddance if your patch works! What's the new PASS? It's "PASS: gdb.cp/templates.exp: destructor breakpoint". (Big surprise, no? Destructors just seem to work if they are not considered "special." :-) Now, there might be ways to tickle something that this patch removes, but my belief is that we can always dig up the code out of CVS and reapply, this time with appropriate comments and test cases to explain WHY it is necessary. Keith PS. Tom Tromey pointed out to me that if this patch goes in, the function "get_destructor_fn_field" will become superfluous. I will, of course, submit a revised patch for that when/if the time comes.