From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c2Q9DTx7TGjh4gwAWB0awg (envelope-from ) for ; Fri, 13 Jun 2025 15:25:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749842748; bh=LwR3CX/VJOgmgiQDXVybzrR7MR95/InCLJCmZk9lhpU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=meDGwF2xYpbmFp+X8A/2D45iy6GSBbHLZs8VuVPicm68uF/LoVPv4H5O5ayG7uFs6 O05A4uMMv5AfEOPkks9sOY2DcWf62qto5Mr/YwNPaVM5bCgTjBc8Nhk3NN+P+jdd9a tt7Nn+b/HXM6kRc1iNqE5QPRrqXcPTFShaUzpMuY= Received: by simark.ca (Postfix, from userid 112) id 21F971E102; Fri, 13 Jun 2025 15:25:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=p0YXmG8O; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=bzN7EZbb; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C3AD1E0C2 for ; Fri, 13 Jun 2025 15:25:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11757380ED04 for ; Fri, 13 Jun 2025 19:25:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 11757380ED04 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=p0YXmG8O; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=bzN7EZbb Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EEBA0380ED00 for ; Fri, 13 Jun 2025 19:24:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEBA0380ED00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EEBA0380ED00 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749842693; cv=none; b=JDSzc5sRyMFywA9k1TPrS6sDHa3TfnQ7/7eRrU84Fz0C//8+FQDKUfLCRotnKzYAhUOawfq/i5+5CyLS96fIzh2Dxu4becMxgUhEanAklkazADGu/f2trzhVw+Br7OLSUOi713iO/fhlBKgBj3FiMWVpdheV1dRY+ThwtzP3DnA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749842693; c=relaxed/simple; bh=LwR3CX/VJOgmgiQDXVybzrR7MR95/InCLJCmZk9lhpU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=Rcai0KWZ4eLNJoTjlWBizoq27IxNLrv2fz4LaCNHmwSfMcyQLJNJ0LupvWPjGkvr4+0Aird5i7bFNLWqXk/DQXrRedFxvMtdO6576ug2GgshJYgXS0n7gN9vLIPt//zM89CzEQp6EdukyVBiZGsEpg/0whJUhMkaYFdsGtwqbI0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEBA0380ED00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749842692; bh=LwR3CX/VJOgmgiQDXVybzrR7MR95/InCLJCmZk9lhpU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=p0YXmG8OXTgxVpWe5imLrA5/lDp+gO28J+92INyTNOrfXFxCKPsbnkSy3EwEIwK7d /NzSUJMQ5id9qWcKpunoD9O1rvG5kTkWCcyAu/o/YcmAAtBr+omSpOiUN0FBh9rxuw RflP+Ft8dUziRlOVm4jDNUXoDM70+AQ+qXzXNMf0= Received: by simark.ca (Postfix, from userid 112) id AAE511E126; Fri, 13 Jun 2025 15:24:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1749842691; bh=LwR3CX/VJOgmgiQDXVybzrR7MR95/InCLJCmZk9lhpU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bzN7EZbbrT/XngoqAkqnsv+6X1oAC8jCXT6iUtp/LjNjS/kG0LctQL8vccf2eP3Eg WmQY5rnr02dmWjenOTZcr0Tk6YMNpMCndy5/VZsVROToAY+gslbV50D3HAj9UcgkGx R1FN1sPUz2Sz+ohRP5/sBFWbNwDm5W1Hx9HOl3O4= Received: from [172.16.0.192] (192-222-132-26.qc.cable.ebox.net [192.222.132.26]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 43C591E0C2; Fri, 13 Jun 2025 15:24:51 -0400 (EDT) Message-ID: <497f7bb1-f852-4551-abdb-d6d98e741234@simark.ca> Date: Fri, 13 Jun 2025 15:24:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] gdbsupport: factor out work queue from parallel-for.h To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20250505201548.184917-1-simon.marchi@efficios.com> <20250505201548.184917-4-simon.marchi@efficios.com> <87plf7jxuo.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87plf7jxuo.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/13/25 2:33 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> In preparation for a following patch that will re-use the shared work > Simon> queue algorithm, move it to a separate class. > > Patch 3 said: > > +parallel_for_each (const RandomIt first, const RandomIt last, > + WorkerArgs &&...worker_args) > > Simon> + /* The work items are specified by the range `[first, last[`. */ > Simon> + work_queue (RandomIt first, RandomIt last) noexcept > Simon> + : m_next (first), > Simon> + m_last (last) > > So I was wondering why not 'const RandomIt' here. > And then 'const RandomIt m_last;' Hmm, probably an oversight. It works when I add the consts, so I'll update this patch. Simon