From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ejq+CeX9AmrgXjMAWB0awg (envelope-from ) for ; Tue, 12 May 2026 06:16:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NX8UsPXs; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7tvVlik+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NX8UsPXs; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7tvVlik+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F24941E0C3; Tue, 12 May 2026 06:16:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CEFFA1E093 for ; Tue, 12 May 2026 06:16:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDE214BAD145 for ; Tue, 12 May 2026 10:16:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDE214BAD145 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NX8UsPXs; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7tvVlik+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NX8UsPXs; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7tvVlik+ Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 50B564BA23F7 for ; Tue, 12 May 2026 10:15:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50B564BA23F7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50B564BA23F7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778580924; cv=none; b=gHxL00+GCGnAeicFJJEK0uxIzFTiEi7Kb+8zHCjtM7g8vNUR9AHrOgLtXd9CuQCr4M/zgqbuK3tWtZNu/tsUHKbsAgpGqfRzwKULrollxpD4DT6KBlQx2xADF6AHJ9LtbXqM3g4qX/XXhsV5qNXMtM4qVz+kzV61s7BEFPFJ58w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778580924; c=relaxed/simple; bh=uu3bl9Y3ycnOmdKHLyP70WjGaOUDbgGSjrLixw6Xop0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=LWADKI6EP8cCHy4fiINv9Mg0ylFH0N9Xw+lC5RzKpnWhO4s1ZOkcvOFh1+Gqkse5VauLa9JtGk/tsvgo5eLBFJBeA67wvMuG3OBRXWEPSkFgv8He84LX9R0SwZfNwAfkIkIDAfebnfHDOlDf6IgebeAYTaOaCotGs/mAdi5Xn6I= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NX8UsPXs; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7tvVlik+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NX8UsPXs; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7tvVlik+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50B564BA23F7 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 431E975F2A; Tue, 12 May 2026 10:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778580923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pt+mzXgG+Uu7hEaZcPk4qlxJDCDnKTSFFq1GicroiaA=; b=NX8UsPXsgRdKJpNFqK4UNt1mxJm9FX6oxMkHuprsViBNFF140YVXFHbfgKJgJAzo8DZm6D Vy8NzVkcOD/OvLa+vUe1cykpxCXZpZS6PgRo2v6Kz+D2eeyxSQuM9Zjib+cKzwxI8f9hBk SDQx7wris89p12TPSU2WdwfiA3d0xtA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778580923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pt+mzXgG+Uu7hEaZcPk4qlxJDCDnKTSFFq1GicroiaA=; b=7tvVlik+utLiAebL5297q/9e8sF4TS/iY1Q1EXKQ3+yk5xIHl23TPe+t6qymxUmt00NM4E 7Y9dQqKdyhM9zUCg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NX8UsPXs; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=7tvVlik+ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778580923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pt+mzXgG+Uu7hEaZcPk4qlxJDCDnKTSFFq1GicroiaA=; b=NX8UsPXsgRdKJpNFqK4UNt1mxJm9FX6oxMkHuprsViBNFF140YVXFHbfgKJgJAzo8DZm6D Vy8NzVkcOD/OvLa+vUe1cykpxCXZpZS6PgRo2v6Kz+D2eeyxSQuM9Zjib+cKzwxI8f9hBk SDQx7wris89p12TPSU2WdwfiA3d0xtA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778580923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pt+mzXgG+Uu7hEaZcPk4qlxJDCDnKTSFFq1GicroiaA=; b=7tvVlik+utLiAebL5297q/9e8sF4TS/iY1Q1EXKQ3+yk5xIHl23TPe+t6qymxUmt00NM4E 7Y9dQqKdyhM9zUCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2B497593A9; Tue, 12 May 2026 10:15:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id exIICbv9AmoeZQAAD6G6ig (envelope-from ); Tue, 12 May 2026 10:15:23 +0000 Message-ID: <497953ba-25a2-494e-a207-e01f54af8882@suse.de> Date: Tue, 12 May 2026 12:15:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] [gdb/exp] Fix ignoring of incorrect namespace prefix To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260419081236.570600-1-tdevries@suse.de> <20260419081236.570600-3-tdevries@suse.de> <871pfuhq31.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <871pfuhq31.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 431E975F2A X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/1/26 9:44 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> + const char *current_scope = (block->function_block () != nullptr > Tom> + ? block->scope () > Tom> + : nullptr /* Don't know. */); > > Calling block::scope would yield "" even for the static block case. > So I was wondering why not use that rather than check function_block? > But like I said elsewhere, I don't really follow this function that well. AFAIU, you're proposing the following: ... if (len == 0) { const char *current_scope = block->scope (); directive_match = streq (scope, current_scope); } ... That runs into the following regressions: ... FAIL: gdb.cp/namespace.exp: print X FAIL: gdb.cp/namespace.exp: print 'G::Xg' FAIL: gdb.cp/namespace.exp: print G::Xg FAIL: gdb.cp/namespace.exp: print G::XgX ... The first can be reproduced like this: ... $ gdb -q -batch outputs/gdb.cp/namespace/namespace \ -ex "b marker2" -ex run \ -ex "print X" ... No symbol "X" in current context. ... The relevant bit of test-case source is: ... namespace { int X = 9; } namespace C { namespace D { void marker2 (void) { ... } } } ... So we're in cp_lookup_symbol_via_imports, with: - scope == "C::D" - name == "X", - block == static block and when looking at (AFAIU) implicit import: ... (gdb) p *current $3 = {import_src = 0x348dac0 "(anonymous namespace)", import_dest = 0x1b477a0 "", alias = 0x0, declaration = 0x0, next = 0x0, decl_line = 0, searched = 0, excludes = {0x0}} ... we're trying to figure out directive_match. In this case directive_match needs to be true for the test to pass, but we have scope == "C::D" and current_scope == "", so streq (scope, current_scope) == false. So I've left this patch as is in a v6. Thanks, - Tom