From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AV+iILp7lWlr6T8AWB0awg (envelope-from ) for ; Wed, 18 Feb 2026 03:43:38 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=18MlN+TB; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nP1UrXv5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MTyvuESL; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DteXRtJi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6A58E1E089; Wed, 18 Feb 2026 03:43:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1CD631E089 for ; Wed, 18 Feb 2026 03:43:36 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A01284B9DB49 for ; Wed, 18 Feb 2026 08:43:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A01284B9DB49 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=18MlN+TB; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nP1UrXv5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MTyvuESL; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DteXRtJi Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id F31394BA23CA for ; Wed, 18 Feb 2026 08:43:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F31394BA23CA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F31394BA23CA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771404186; cv=none; b=XwEi7Q0EAUV625AwCReu7SynvLCKoneHxaR7MeF8xYSeqS+rneR8k+zjGIqzpE7wGKHlkARMkTrJiiBVIlNDzm191yS0rPpoTktFO9d3I9bTGd6/siodo4kt3leJxA18IMg9TU8RcO3cRriMPFt5i90YBYakmUBW1TrVILULE/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771404186; c=relaxed/simple; bh=GTP1+JEBY1CyBY1AehxERXOjF6JIjkj0G6eR021+jS0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=QsAVZ+JtKrRt5Fi8/D6mhMtK73ZJUf5wy1r43rY6sqBRbhO+lAU2qfM805qHPhg0T5CAk/EFpz47oC94tXDdwDQ//6vaDMLMqgmU5RWi8mM/z7NqIfye/hsLSQFWxcaQmqoowQ52aDkMekNuYfIYPxf74f2C2qvsVNVqQX+IdC4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F31394BA23CA Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D50883E6FA; Wed, 18 Feb 2026 08:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771404185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6D7lAwIXMTmO9exyHVRS0hlzGeBioGcFWOQOyxUP98U=; b=18MlN+TB/Tyhu5UW+qjjiBUUJ/J2TSfx8I9hrEGrbKLhWfyu4gqHGZpcwU4AiANdFSoVSM kYl+MwKkO8xwTkMAmC+R6Zqyhkw6/Z/WBS8SpbuC1fJoHb7jJSM/yX227FHpqfXpVrlIQu 8VQ+MDXSvah07QTaPm0CxsgampbHmYs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771404185; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6D7lAwIXMTmO9exyHVRS0hlzGeBioGcFWOQOyxUP98U=; b=nP1UrXv5FGQCLpkzLaIgJ/TuOxQDhejxUMLQRpfkR13PHyfDKQZahAIxaKzAq5b8PjId6W q/4pmJEI4JzrnBDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MTyvuESL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DteXRtJi DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771404184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6D7lAwIXMTmO9exyHVRS0hlzGeBioGcFWOQOyxUP98U=; b=MTyvuESLv8W5+nEZMI83EyQ+hIQk42yioe0S/J7SezxVjKOCj1OjYuh/yp0WGC0MSKFkB0 8+nMp0H5Kj1vEEMcAucc07PEETkh0sYRPQ0HA5GBc0IWp5boryKX5w12VcgoLMlq6amV+C SAd+ZN6qB6VtnehTrmjroDuS6Tq7Zec= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771404184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6D7lAwIXMTmO9exyHVRS0hlzGeBioGcFWOQOyxUP98U=; b=DteXRtJivkDm0QsaBL6H6K+Sgd5Y9Z6NnMZdZRYni//GjUyKIUp7a5nY01P+ts4Lvzf0vu npMv9pmJfctk8xBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B436C3EA66; Wed, 18 Feb 2026 08:43:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1JGfKph7lWmUNAAAD6G6ig (envelope-from ); Wed, 18 Feb 2026 08:43:04 +0000 Message-ID: <495d90f1-2a63-4f20-ac8d-4c389e9992e8@suse.de> Date: Wed, 18 Feb 2026 09:43:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gcore: Query auxv for AT_PAGESZ in gcore_copy_callback To: Kevin Buettner , gdb-patches@sourceware.org References: <20260218021217.1821113-1-kevinb@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260218021217.1821113-1-kevinb@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: D50883E6FA X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/18/26 3:09 AM, Kevin Buettner wrote: > This is a followup patch to commit c1da013915e, titled "gcore: Handle > unreadable pages within readable memory regions". > > In his review of that earlier patch, Tom de Vries recommended using > target_auxv_search with AT_PAGESZ to find the page size if it's > available; this patch implements that suggestion. As before, a 4k > fallback size is used should the search for an AT_PAGESZ value not > succeed. Hi Kevin, LGTM. Approved-By: Tom de Vries Thanks, - Tom > --- > gdb/gcore.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/gdb/gcore.c b/gdb/gcore.c > index 7bf2f00e866..66a9f6c4153 100644 > --- a/gdb/gcore.c > +++ b/gdb/gcore.c > @@ -36,6 +36,7 @@ > #include "gdbsupport/gdb_unlinker.h" > #include "gdbsupport/byte-vector.h" > #include "gdbsupport/scope-exit.h" > +#include "auxv.h" > > /* To generate sparse cores, we look at the data to write in chunks of > this size when considering whether to skip the write. Only if we > @@ -766,6 +767,11 @@ gcore_copy_callback (bfd *obfd, asection *osec) > size = std::min (total_size, (bfd_size_type) MAX_COPY_BYTES); > gdb::byte_vector memhunk (size); > > + bfd_size_type page_size = FALLBACK_PAGE_SIZE; > + CORE_ADDR at_pagesz; > + if (target_auxv_search (AT_PAGESZ, &at_pagesz) > 0) > + page_size = (bfd_size_type) at_pagesz; > + > while (total_size > 0) > { > if (size > total_size) > @@ -786,8 +792,7 @@ gcore_copy_callback (bfd *obfd, asection *osec) > > while (remaining > 0) > { > - bfd_size_type chunk_size > - = std::min (remaining, (bfd_size_type) FALLBACK_PAGE_SIZE); > + bfd_size_type chunk_size = std::min (remaining, page_size); > > if (target_read_memory (addr, p, chunk_size) != 0) > {