From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-154112-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 115322 invoked by alias); 23 Feb 2019 00:32:12 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 115255 invoked by uid 89); 23 Feb 2019 00:32:11 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*M:328e
X-HELO: mail-wm1-f41.google.com
Received: from mail-wm1-f41.google.com (HELO mail-wm1-f41.google.com) (209.85.128.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Feb 2019 00:32:09 +0000
Received: by mail-wm1-f41.google.com with SMTP id n19so3431178wmi.1        for <gdb-patches@sourceware.org>; Fri, 22 Feb 2019 16:32:09 -0800 (PST)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:75e6:857f:3506:a1f4? ([2001:8a0:f913:f700:75e6:857f:3506:a1f4])        by smtp.gmail.com with ESMTPSA id q135sm3144894wme.43.2019.02.22.16.32.02        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Fri, 22 Feb 2019 16:32:05 -0800 (PST)
Subject: Re: [RFC] Fix BFD leak in solib-darwin.c
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
References: <20190222163645.9349-1-tromey@adacore.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <49527b82-328e-e129-21d1-cbc333c70ca7@redhat.com>
Date: Sat, 23 Feb 2019 00:32:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190222163645.9349-1-tromey@adacore.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-02/txt/msg00379.txt.bz2

On 02/22/2019 04:36 PM, Tom Tromey wrote:
>        if (sub != NULL)
>  	dyld_bfd = sub;
>        else
> -	dyld_bfd.release ();
> +	dyld_bfd.reset (nullptr);

These 4 lines are now equivalent to just doing:

   dyld_bfd = sub;

Thanks,
Pedro Alves