From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10503 invoked by alias); 11 Dec 2008 08:50:51 -0000 Received: (qmail 10489 invoked by uid 22791); 11 Dec 2008 08:50:50 -0000 X-Spam-Check-By: sourceware.org Received: from eu1sys200aog114.obsmtp.com (HELO eu1sys200aog114.obsmtp.com) (207.126.144.137) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Dec 2008 08:49:47 +0000 Received: from source ([164.129.1.35]) (using TLSv1) by eu1sys200aob114.postini.com ([207.126.147.11]) with SMTP ID DSNKSUDUH9ImSi65VCQ1NSYjrL7Nzi4zoXfm@postini.com; Thu, 11 Dec 2008 08:49:41 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A7653DAC9; Thu, 11 Dec 2008 08:49:25 +0000 (GMT) Received: from mail2.gnb.st.com (mail2.gnb.st.com [164.129.119.59]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 9F9704BF57; Thu, 11 Dec 2008 08:49:32 +0000 (GMT) Received: from [164.129.122.46] (gnx2504.gnb.st.com [164.129.122.46]) by mail2.gnb.st.com (MOS 3.8.7a) with ESMTP id CYR28701 (AUTH lyon); Thu, 11 Dec 2008 09:49:42 +0100 (CET) Message-ID: <4940D41C.4040206@st.com> Date: Thu, 11 Dec 2008 08:50:00 -0000 From: Christophe LYON User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: Carlos Eduardo Seo Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite gdb.base/expand-psymtabs: ensure code is generated for the expected source line References: <493D3C16.3010303@st.com> <493FFC31.7070005@linux.vnet.ibm.com> In-Reply-To: <493FFC31.7070005@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00197.txt.bz2 On 10.12.2008 18:28, Carlos Eduardo Seo wrote: > Christophe LYON wrote: >> I propose the attached small patch to expand-psymtabs.c. The goal is to >> make sure the compiler actually generates code and debug information for >> the expected line. Currently, our compiler attaches code only to the >> opening brace, hence causing the test to fail. >> > > Just curious... which compiler are you using? > > gcc generates the right code for the purpose of the test using both > (patched and unpatched) testcases. So, if everyone else agrees, I'm fine > with your modification. > > Regards, > We are using Open64. Its front-end is based on GCC but the "trees" are converted into Whirl (Open64 Internal Representation) rather early. We have ported it to internal targets, and on a few occasions, I already submitted this kind of small patches. Christophe.