From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29527 invoked by alias); 10 Dec 2008 17:29:06 -0000 Received: (qmail 29518 invoked by uid 22791); 10 Dec 2008 17:29:05 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Dec 2008 17:28:22 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw2.br.ibm.com (Postfix) with ESMTP id 1471717F4DB for ; Wed, 10 Dec 2008 14:11:28 -0200 (BRDT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mBAIRpYK3719184 for ; Wed, 10 Dec 2008 15:27:51 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mBAHSGWx012237 for ; Wed, 10 Dec 2008 15:28:16 -0200 Received: from [9.8.3.90] ([9.8.3.90]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mBAHSGGf012226; Wed, 10 Dec 2008 15:28:16 -0200 Message-ID: <493FFC31.7070005@linux.vnet.ibm.com> Date: Wed, 10 Dec 2008 17:29:00 -0000 From: Carlos Eduardo Seo User-Agent: Thunderbird 2.0.0.18 (X11/20081128) MIME-Version: 1.0 To: Christophe LYON CC: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite gdb.base/expand-psymtabs: ensure code is generated for the expected source line References: <493D3C16.3010303@st.com> In-Reply-To: <493D3C16.3010303@st.com> OpenPGP: id=8BFFA900 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00190.txt.bz2 Christophe LYON wrote: > I propose the attached small patch to expand-psymtabs.c. The goal is to > make sure the compiler actually generates code and debug information for > the expected line. Currently, our compiler attaches code only to the > opening brace, hence causing the test to fail. > Just curious... which compiler are you using? gcc generates the right code for the purpose of the test using both (patched and unpatched) testcases. So, if everyone else agrees, I'm fine with your modification. Regards, -- Carlos Eduardo Seo Software Engineer IBM Linux Technology Center