From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18830 invoked by alias); 4 Dec 2008 09:38:58 -0000 Received: (qmail 18815 invoked by uid 22791); 4 Dec 2008 09:38:57 -0000 X-Spam-Check-By: sourceware.org Received: from eu1sys200aog101.obsmtp.com (HELO eu1sys200aog101.obsmtp.com) (207.126.144.111) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Dec 2008 09:38:07 +0000 Received: from source ([164.129.1.35]) (using TLSv1) by eu1sys200aob101.postini.com ([207.126.147.11]) with SMTP ID DSNKSTek9GIh1bN7evxSGZ7I6UBTuD4Ay6NX@postini.com; Thu, 04 Dec 2008 09:38:06 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 23A74DA9E; Thu, 4 Dec 2008 09:37:35 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 79CF84BF0B; Thu, 4 Dec 2008 09:37:40 +0000 (GMT) Received: from crx595.cro.st.com (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.8.7a) with ESMTP id CQV22052 (AUTH "denis pilat"); Thu, 4 Dec 2008 10:37:48 +0100 (CET) Message-ID: <4937A4E3.4040609@st.com> Date: Thu, 04 Dec 2008 09:38:00 -0000 From: Denis PILAT User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: Doug Evans Cc: Michael Snyder , Jon Beniston , "gdb-patches@sourceware.org" Subject: Re: Patch to support spaces in filenames & paths References: <7D653316E38B4305941199D722BF20B0@bibi> <4935A5E2.5050503@vmware.com> <20081202233738.GA15530@caradoc.them.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00059.txt.bz2 Doug Evans wrote: > On Tue, Dec 2, 2008 at 3:37 PM, Daniel Jacobowitz wrote: > >> On Tue, Dec 02, 2008 at 01:17:22PM -0800, Michael Snyder wrote: >> >>> Denis, is it possible that Jon's patch will serve in place of >>> the filename portion of your patch? And that you could then >>> resubmit your patch with just the other portions? >>> >>> Jon's patch: >>> http://sourceware.org/ml/gdb-patches/2008-12/msg00032.html >>> >>> Denis' patch: >>> http://sourceware.org/ml/gdb-patches/2008-12/msg00029.html >>> >> I have not looked at the patches in depth but I encourage Denis's >> approach - uniform parsing is a Very Good Thing and buildargv is what >> we use elsewhere. >> > > While perhaps not applicable in Denis' case (since the command accepts > "a b c" instead of "a, b, c" (though I wonder if it could accept > both), for completeness' sake there is also parse_to_comma_and_eval. > > (gdb) printf "%d %d %d\n", 1 + 1, 2 + 2, 3 + 3 > 2 4 6 > > With buildargv it'd be > > (gdb) printf "%d %d %d\n" "1 + 1" "2 + 2" "3 + 3" > > and that just doesn't sit right. :-) > > Actual implementation of append/dump/restore does not accept spaces at all, except in the last argument, and I think it's just a side effect. To me comma must not be considered as a separator since dump command accepts expression and the calculation of START , END address or OFFSET is often a function call like sizeof (), but can be more than that like a function that takes more than one parameters, "max(a,b)" or whatever. I'm fine with using gdb_buildargv, that would simplify my patch (http://sourceware.org/ml/gdb-patches/2008-12/msg00029.html). -- Denis