Re: [RFA] Resubmit process record and replay, 6/10

[Michael Snyder <msnyder@vmware.com>]

teawater wrote:
> Hi Michael,
> 
> About "record_not_record_set", It set record_not_record to let P
> record doesn't record the memory and registers control behaviors of
> GDB in function record_store_registers and record_xfer_partial.
> 
> So I think the name "record_not_record_set" and
> "record_skip_recording" are not very clear.
> Could you please give me some advices on it?

Yeah, that's pretty much the way I understood it.

It sets a one-time flag that says "omit (skip) recording
registers and memory that would otherwise be recorded".

And if I understand correctly, this is to avoid adding
changes to the record log that are made by gdb when it
resumes the target.  It's only called from "proceed()".

I'm not completely clear on what those changes are.
Is gdb modifying the PC?  Or are you perhaps trying to
avoid recording breakpoints?

Is there another way to detect and avoid recording these changes?