From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29691 invoked by alias); 20 Nov 2008 02:03:50 -0000 Received: (qmail 29561 invoked by uid 22791); 20 Nov 2008 02:03:49 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Nov 2008 02:03:14 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 32EC73E018; Wed, 19 Nov 2008 18:03:11 -0800 (PST) Received: from [10.20.92.151] (promb-2s-dhcp151.eng.vmware.com [10.20.92.151]) by mailhost4.vmware.com (Postfix) with ESMTP id 2900AC9A1C; Wed, 19 Nov 2008 18:03:11 -0800 (PST) Message-ID: <4924C55D.2050802@vmware.com> Date: Thu, 20 Nov 2008 05:56:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: teawater CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] Resubmit process record and replay, 8/10 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00528.txt.bz2 teawater wrote: > This patch add code to make I386 architecture support process record and replay. > > 2008-11-16 Hui Zhu > > I386 architecture process record and replay support. > > * i386-tdep.c (PREFIX_REPZ, PREFIX_REPNZ, PREFIX_LOCK, > PREFIX_DATA, PREFIX_ADDR): New macros. Help decode the I386 > instruction. ... Help decode the i386 instruction set. > (aflag, dflag, override, modrm, mod, reg, rm, ot, > i386_record_pc): New variables. Ditto. > (i386_record_modrm, i386_record_lea_modrm_addr, > i386_record_lea_modrm): New functions. Ditto. > (i386_process_record): New function. Parse the instruction in > address "addr" and record the values of registers and memory > that will be change in this instruction. ... that will be changed by this instruction. > (i386_gdbarch_init): Set "i386_process_record" to GDBARCH > "process_record" interface. > * i386-tdep.h (gdbarch_tdep): New function pointers > "i386_intx80_record" and "i386_sysenter_record" that point to > the function can record "intx80" and "sysenter" execute log. ... the function that can record [...] execution log. > > i386-tdep.c | 2964 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > i386-tdep.h | 3 > 2 files changed, 2967 insertions(+) > > Following is the diff with the previous patch: Hmm, I'm not the master of protocol here (Joel?), but my impression is that we would prefer to see the diffs against the current CVS, not against the previous patch. If there's important changes since the previous patch, could you maybe include a brief description of the changes? Thanks, Michael