From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19661 invoked by alias); 18 Nov 2008 16:07:42 -0000 Received: (qmail 19283 invoked by uid 22791); 18 Nov 2008 16:07:39 -0000 X-Spam-Check-By: sourceware.org Received: from mail.oarcorp.com (HELO OARmail.OARCORP.com) (216.186.189.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 16:06:41 +0000 Received: from [192.168.1.3] (192.168.1.3) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.1.311.2; Tue, 18 Nov 2008 10:02:59 -0600 Message-ID: <4922E80C.4040303@oarcorp.com> Date: Tue, 18 Nov 2008 21:23:00 -0000 From: Joel Sherrill User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Doug Evans CC: "gdb-patches@sourceware.org" Subject: Re: System V IPC for psim try #2 References: <491DA162.3030402@oarcorp.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00469.txt.bz2 Doug Evans wrote: > On Fri, Nov 14, 2008 at 8:03 AM, Joel Sherrill > wrote: > >> Hi, >> >> I think I have taken Doug's comments into account >> with this revised version of the patch. Hopefully >> it is ready to commit now. >> >> Comments appreciated. Thanks. >> >> 2008-11-14 Joel Sherrill >> >> * Makefile.in, configure.ac, debug.c, debug.h, hw_sem.c, hw_shm.c: >> Add support for System V shared memory and semaphores to PSIM where >> available on the host. Shared memory can be mapped into the >> simulated processor's address space and protected using a semaphore. >> * configure: Regenerated. >> > > Hi. Thanks for the making the changes. > Thank you for reviewing it. Is is OK to commit now with the ChangeLog you preferred? > nit: I think the convention is one *-line per file, though I see > sim/ppc/ChangeLog doesn't follow that rule precisely. I like your > original changelog entry better (fwiw). > > 2008-09-08 Joel Sherrill > > * configure: Regenerated. > * configure.ac: Add test for System V shared memory and semaphore. > * debug.c, debug.h: Add trace support for new devices. > * hw_sem.c, hw_shm.c: New files. > * Makefile.in: Add hw_sem.c and hw_shm.c. > > That is a more informative log. > Regarding: > > +if test "$ac_cv_has_union_semun" = "yes"; then > + AC_CACHE_CHECK(whether System V semaphores are supported, > + ac_cv_sysv_sem, > + [ > + AC_TRY_RUN( > + [ > > Apologies for not noting this before. I see ppc/configure.ac already > uses AC_TRY_RUN, so it's ok with me. The problem with AC_TRY_RUN is > that it doesn't work in cross compilation environments. In this case > all that will happen is that the sim won't support these extra > features so no big deal (And apologies if all of this has already gone > through your mind ... :-)) > No it hadn't gone through my mind. I just assumed that those who had come before me had good reasons to use it. --joel -- Joel Sherrill, Ph.D. Director of Research & Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985