From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19502 invoked by alias); 18 Nov 2008 01:32:13 -0000 Received: (qmail 19430 invoked by uid 22791); 18 Nov 2008 01:32:12 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 01:31:35 +0000 Received: (qmail 23341 invoked from network); 18 Nov 2008 01:31:34 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Nov 2008 01:31:34 -0000 Message-ID: <49221AE9.5050600@codesourcery.com> Date: Tue, 18 Nov 2008 17:20:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: Tristan Gingold CC: gdb-patches@sourceware.org Subject: Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c) References: <7B1402FF-6CAB-4C6A-AAB5-81E062080FB5@adacore.com> In-Reply-To: <7B1402FF-6CAB-4C6A-AAB5-81E062080FB5@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00457.txt.bz2 Tristan Gingold wrote: > > typedef struct oso_el > { Something about what this struct is for, please? And while you and I know that "oso" is short for "other source" and refers to the collection of debug info from .o files, it's new to everybody else. :-) (Getting function bounds set correctly is going to be loads of fun, ahem, I had to look at Apple's hairy code for this several months ago...) > DEF_VEC_O(oso_el); > static VEC(oso_el) *oso_vector; The vector macros should follow the "space before paren" just as everybody else does, although I note that the doc in vec.h confuses things by not following the general rule. > #define DSYM_SUFFIX ".dSYM/Contents/Resources/DWARF/" Again, need to say what dSYM files are, and maybe mention that the yucky wired-in string is guaranteed to have that form (or at least that we're doing the same thing as Apple's GDB). In comments, we should prefer to say "Mach-O" rather than "macho" or "mach-o", since that is the proper name of the file format. With these doc and formatting changes, machoread.c is OK to go into the trunk. (Ideally we will migrate this file to the list of generic files, but we will need to check that it compiles on other hosts first.) Stan