Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Doug Evans <dje@google.com>
Cc: "eliz@gnu.org" <eliz@gnu.org>,
	  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] fix some punctuation and capitalization errors in infcall.c
Date: Mon, 17 Nov 2008 19:51:00 -0000	[thread overview]
Message-ID: <4920D620.5080600@vmware.com> (raw)
In-Reply-To: <e394668d0811151535tf914a44t98af6130c4f0b0e0@mail.gmail.com>

Let's ship it then.

Doug Evans wrote:
> Tested on i386-linux.
> 
> On Sat, Nov 15, 2008 at 3:33 PM, Michael Snyder <msnyder@vmware.com> wrote:
>> If they were comments, they'd be obvious.
>>
>> Since they change visible output, have you run the testsuites
>> to see if they affect any tests?
>>
>> Doug Evans wrote:
>>> While hacking in infcall.c I found a few nits.
>>> At least I think these are nits based on what I found elsewhere in the
>>> tree.
>>>
>>> Ok to check in?
>>>
>>> 2008-11-15  Doug Evans  <dje@google.com>
>>>
>>>        * infcall.c (call_function_by_hand): Fix punctuation and
>>> capitalization
>>>        on error messages.
>>>
>>>        * gdb.mi/mi-syn-frame.exp: Update expected output.
>>>        * gdb.mi/mi2-syn-frame.exp: Update expected output.
>>>
>>> Index: infcall.c
>>> ===================================================================
>>> RCS file: /cvs/src/src/gdb/infcall.c,v
>>> retrieving revision 1.105
>>> diff -u -p -u -p -r1.105 infcall.c
>>> --- infcall.c   12 Nov 2008 00:39:28 -0000      1.105
>>> +++ infcall.c   15 Nov 2008 22:43:10 -0000
>>> @@ -339,7 +339,7 @@ call_function_by_hand (struct value *fun
>>>   gdbarch = get_frame_arch (frame);
>>>     if (!gdbarch_push_dummy_call_p (gdbarch))
>>> -    error (_("This target does not support function calls"));
>>> +    error (_("This target does not support function calls."));
>>>     /* Create a cleanup chain that contains the retbuf (buffer
>>>      containing the register values).  This chain is create BEFORE the
>>> @@ -529,7 +529,7 @@ call_function_by_hand (struct value *fun
>>>     }
>>>     if (nargs < TYPE_NFIELDS (ftype))
>>> -    error (_("too few arguments in function call"));
>>> +    error (_("Too few arguments in function call."));
>>>     {
>>>     int i;
>>> @@ -754,7 +754,7 @@ The program being debugged exited while
>>>  error (_("\
>>>  The program being debugged was signaled while in a function called from
>>> GDB.\n\
>>>  GDB has restored the context to what it was before the call.\n\
>>> -To change this behavior use \"set unwindonsignal off\"\n\
>>> +To change this behavior use \"set unwindonsignal off\".\n\
>>>  Evaluation of the expression containing the function (%s) will be
>>> abandoned."),
>>>                     name);
>>>            }
>>> @@ -774,7 +774,7 @@ Evaluation of the expression containing
>>>  error (_("\
>>>  The program being debugged was signaled while in a function called from
>>> GDB.\n\
>>>  GDB remains in the frame where the signal was received.\n\
>>> -To change this behavior use \"set unwindonsignal on\"\n\
>>> +To change this behavior use \"set unwindonsignal on\".\n\
>>>  Evaluation of the expression containing the function (%s) will be
>>> abandoned."),
>>>                     name);
>>>            }
>>


      reply	other threads:[~2008-11-17  2:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16  8:25 Doug Evans
2008-11-16  8:26 ` Michael Snyder
2008-11-16  8:27   ` Doug Evans
2008-11-17 19:51     ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4920D620.5080600@vmware.com \
    --to=msnyder@vmware.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox