From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3759 invoked by alias); 15 Nov 2008 23:35:11 -0000 Received: (qmail 3702 invoked by uid 22791); 15 Nov 2008 23:35:10 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 15 Nov 2008 23:34:35 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 39B613A00E; Sat, 15 Nov 2008 15:34:34 -0800 (PST) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost2.vmware.com (Postfix) with ESMTP id 21E138E57F; Sat, 15 Nov 2008 15:34:34 -0800 (PST) Message-ID: <491F5C64.90704@vmware.com> Date: Sun, 16 Nov 2008 08:26:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Doug Evans CC: "eliz@gnu.org" , "gdb-patches@sourceware.org" Subject: Re: [RFA] fix some punctuation and capitalization errors in infcall.c References: <20081115231610.E142C1C7515@localhost> In-Reply-To: <20081115231610.E142C1C7515@localhost> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00403.txt.bz2 If they were comments, they'd be obvious. Since they change visible output, have you run the testsuites to see if they affect any tests? Doug Evans wrote: > While hacking in infcall.c I found a few nits. > At least I think these are nits based on what I found elsewhere in the tree. > > Ok to check in? > > 2008-11-15 Doug Evans > > * infcall.c (call_function_by_hand): Fix punctuation and capitalization > on error messages. > > * gdb.mi/mi-syn-frame.exp: Update expected output. > * gdb.mi/mi2-syn-frame.exp: Update expected output. > > Index: infcall.c > =================================================================== > RCS file: /cvs/src/src/gdb/infcall.c,v > retrieving revision 1.105 > diff -u -p -u -p -r1.105 infcall.c > --- infcall.c 12 Nov 2008 00:39:28 -0000 1.105 > +++ infcall.c 15 Nov 2008 22:43:10 -0000 > @@ -339,7 +339,7 @@ call_function_by_hand (struct value *fun > gdbarch = get_frame_arch (frame); > > if (!gdbarch_push_dummy_call_p (gdbarch)) > - error (_("This target does not support function calls")); > + error (_("This target does not support function calls.")); > > /* Create a cleanup chain that contains the retbuf (buffer > containing the register values). This chain is create BEFORE the > @@ -529,7 +529,7 @@ call_function_by_hand (struct value *fun > } > > if (nargs < TYPE_NFIELDS (ftype)) > - error (_("too few arguments in function call")); > + error (_("Too few arguments in function call.")); > > { > int i; > @@ -754,7 +754,7 @@ The program being debugged exited while > error (_("\ > The program being debugged was signaled while in a function called from GDB.\n\ > GDB has restored the context to what it was before the call.\n\ > -To change this behavior use \"set unwindonsignal off\"\n\ > +To change this behavior use \"set unwindonsignal off\".\n\ > Evaluation of the expression containing the function (%s) will be abandoned."), > name); > } > @@ -774,7 +774,7 @@ Evaluation of the expression containing > error (_("\ > The program being debugged was signaled while in a function called from GDB.\n\ > GDB remains in the frame where the signal was received.\n\ > -To change this behavior use \"set unwindonsignal on\"\n\ > +To change this behavior use \"set unwindonsignal on\".\n\ > Evaluation of the expression containing the function (%s) will be abandoned."), > name); > }