From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27890 invoked by alias); 14 Nov 2008 23:25:51 -0000 Received: (qmail 27621 invoked by uid 22791); 14 Nov 2008 23:25:50 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Nov 2008 23:25:15 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 6199826003; Fri, 14 Nov 2008 15:25:13 -0800 (PST) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost2.vmware.com (Postfix) with ESMTP id 46FF98E561; Fri, 14 Nov 2008 15:25:13 -0800 (PST) Message-ID: <491E08BF.2050609@vmware.com> Date: Sat, 15 Nov 2008 18:51:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: Paul Pluzhnikov CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] [patch] 'info symbol' to print more info References: <20081114204617.A4A533A6B15@localhost> <491DF12A.5090903@vmware.com> <8ac60eac0811141406h4bb126c0sbd898e7d612f46dd@mail.gmail.com> In-Reply-To: <8ac60eac0811141406h4bb126c0sbd898e7d612f46dd@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00382.txt.bz2 Paul Pluzhnikov wrote: > On Fri, Nov 14, 2008 at 1:44 PM, Michael Snyder wrote: > >> Just one suggestion (and suggestion only) -- since the exec_file >> is sort of the default/common case, do you think it would be a >> good idea to check if it's the exec_file, and omit the objfile >> information if so? > > I think there are two large classes of users: > - embedded people with no shared libraries and a single (statically > linked) executable, and > - everybody else. > > I've never been in the first camp. From the second camp, if the > symbol is in the main executable, I want to know that too. > > E.g. if I do 'info symbol &malloc', and it tells me .text in a.out, > that may well be a very important clue (that something unusual is > happening). > > I do agree that for the fully-static executable case the extra > verbiage may be somewhat annoying. Looking for a way to tell if > that is the case ... Would the test below be sufficient? > > if (ojbect_files->next) > /* there is only one object, so don't print its name ... */ Yeah, that's suitable. Thanks.