From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14717 invoked by alias); 14 Jul 2018 01:19:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14704 invoked by uid 89); 14 Jul 2018 01:19:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=guile X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 01:19:28 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A81C81E48F; Fri, 13 Jul 2018 21:19:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531531166; bh=R5w+ogiK1/ktkIrxVIdA7ykGNNinPEsgXjnpdyX3qPk=; h=Subject:To:References:From:Date:In-Reply-To:From; b=Pzzs3ZxmB6yXrX4vguq/qHR4gKPW4GyGWmf+pvcCgO5IrfilESU0XJLG5sOLhU2Ox KRsw1XJCEacwQ6BzDPAa59KrUvQexUr+Ytr1lkUFsnNJhNUAKbbwbAaL0HIhJrLHYL LfdojFXLXboBKm3xLMGEje4mGNxRHtvZhBj171dc= Subject: Re: [RFA 04/13] Call some functions in guile/ for effect To: Tom Tromey , gdb-patches@sourceware.org References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-5-tom@tromey.com> From: Simon Marchi Message-ID: <490c9b62-f209-e5b6-e47d-615d64a39451@simark.ca> Date: Sat, 14 Jul 2018 01:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180712205208.32646-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00440.txt.bz2 On 2018-07-12 04:51 PM, Tom Tromey wrote: > This changes a few spots in guile/ to remove a variable declaration > but to still call a function for effect. LGTM, though it would be nice to mention in the comments what is the desired side-effect (if known). Simon