From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OYm7D7mjXGHqJAAAWB0awg (envelope-from ) for ; Tue, 05 Oct 2021 15:12:57 -0400 Received: by simark.ca (Postfix, from userid 112) id 304171EE1B; Tue, 5 Oct 2021 15:12:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3FB771E813 for ; Tue, 5 Oct 2021 15:12:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69DF7385BF93 for ; Tue, 5 Oct 2021 19:12:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69DF7385BF93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633461175; bh=taA+dYO+tPmGKAdEV5fzRV8IX5XH2tNDSz3nagclJN4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=M9smBX89viKnDmXYM4K2jq3FWwbMCRJOVtdYogzSzyFEFM95QpZThq43NjkOq94Mt AJBR2bMtURsyLv40D3e0nxRtfSSdZW/TwEOYghddq1mMMeYEWNyiFhEjfMqa2qJtBT zekiSgenUeNjKQr+o3EhdB671EsTPxWmYrmDYM/c= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E16BE385C404 for ; Tue, 5 Oct 2021 19:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E16BE385C404 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 195JAuPa017478 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 5 Oct 2021 15:11:01 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 195JAuPa017478 Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F2D6B1E813; Tue, 5 Oct 2021 15:10:55 -0400 (EDT) Subject: Re: [PATCH v4 3/4] gdb: Have setter and getter callbacks for settings To: Lancelot SIX , gdb-patches@sourceware.org References: <20210929215011.1489639-1-lsix@lancelotsix.com> <20210929215011.1489639-4-lsix@lancelotsix.com> Message-ID: <4909e2ce-64db-525c-0199-458138c32460@polymtl.ca> Date: Tue, 5 Oct 2021 15:10:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210929215011.1489639-4-lsix@lancelotsix.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 5 Oct 2021 19:10:56 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > @@ -241,13 +295,23 @@ struct setting > gdb_assert (var_type_uses (m_var_type)); > gdb_assert (m_var != nullptr); > > - return *static_cast (m_var); > + if (m_var == nullptr) > + { > + gdb_assert (m_getter != nullptr); > + auto getter = reinterpret_cast> (m_getter); > + return getter (); > + } > + else > + return *static_cast (m_var); While pulling these upstream changes to the ROCm GDB port, I found that we forgot to remove the `gdb_assert (m_var != nullptr)` above. I can fix that when I send a patch that actually uses the getters/setters (which would trigger the assert). Simon