From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20183 invoked by alias); 9 May 2013 18:51:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20162 invoked by uid 89); 9 May 2013 18:51:35 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 09 May 2013 18:51:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r49IpYw8008550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 May 2013 14:51:34 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r49IpWPo019901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 9 May 2013 14:51:33 -0400 From: Tom Tromey From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 16/40] fix varobj.c In-Reply-To: References: Message-Id: <4904a5c8b2929216849840bc807a85ea30300176.1368124285.git.tromey@redhat.com> Date: Thu, 09 May 2013 18:51:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00330.txt.bz2 c_value_of_root is missing a call to do_cleanups at one return. This fixes the problem by removing that return and letting control fall through. * varobj.c (c_value_of_root): Call do_cleanups along all return paths. --- gdb/varobj.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gdb/varobj.c b/gdb/varobj.c index 467e59a..cf1a11f 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -3456,13 +3456,11 @@ c_value_of_root (struct varobj **var_handle) { new_val = evaluate_expression (var->root->exp); } - - return new_val; } do_cleanups (back_to); - return NULL; + return new_val; } static struct value * -- 1.8.1.4