Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Restore leading zeros in remote_thread_alive
Date: Thu, 23 Oct 2008 19:56:00 -0000	[thread overview]
Message-ID: <4900D59F.4070101@vmware.com> (raw)
In-Reply-To: <200810231638.34327.pedro@codesourcery.com>

Pedro Alves wrote:
> On Wednesday 22 October 2008 19:05:09, Michael Snyder wrote:
>> Pedro Alves wrote:
>>
>>> Could you try this out please?  It works here against gdbserver
>>> single|multi-process, and sends a `T000000tid' (tid alive) packet when
>>> multi-process isn't in effect.
>> Thanks for working up the patch -- it works for my target.
> 
> Thanks for testing.
> 
>> However, I must say that I'm not crazy about the idea that
>> we decide whether or not to send leading zeroes based on
>> whether the target is multi-process.  Seems orthogonal
>> and ad hoc.
> 
> I can't think of a valid reason why we'd have this
> inconsistency:

Yeah -- Pedro, I'm going to withdraw the request.
I decided to fix the client (breakage was worse than
I thought -- it was actually discarding the first byte
of data, which only succeeded because it happened to be
zero).

I don't think it's necessary to uglify remote.c to
handle this issue, unles someone else reports a problem
with it -- but I leave the decision up to you.  ;-)

Thanks for your trouble,
Michael


      reply	other threads:[~2008-10-23 19:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22  1:07 Michael Snyder
2008-10-22  1:10 ` Michael Snyder
2008-10-22  1:14 ` Pedro Alves
2008-10-22  2:53 ` Daniel Jacobowitz
2008-10-22 17:43   ` Michael Snyder
2008-10-22 13:19 ` Pedro Alves
2008-10-22 14:17   ` Pedro Alves
2008-10-22 18:10     ` Michael Snyder
2008-10-23 15:39       ` Pedro Alves
2008-10-23 19:56         ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4900D59F.4070101@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox