From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48920 invoked by alias); 10 Jan 2017 16:33:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47329 invoked by uid 89); 10 Jan 2017 16:33:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php, H*u:1.2.3, H*UA:1.2.3, H*f:sk:d074a35 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jan 2017 16:33:43 +0000 Received: by simark.ca (Postfix, from userid 33) id C31A41E81B; Tue, 10 Jan 2017 11:33:41 -0500 (EST) To: Pedro Alves Subject: Re: [PATCH] Change return type of ui_out redirect to void X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 10 Jan 2017 16:33:00 -0000 From: Simon Marchi Cc: Luis Machado , Simon Marchi , gdb-patches@sourceware.org In-Reply-To: References: <20161222220728.15146-1-simon.marchi@ericsson.com> <81609b60-0821-3f1b-7613-5bf691727d5f@codesourcery.com> <4270f5e03af2b1e554fc4ddaf1a0a8c7@polymtl.ca> Message-ID: <48d83f3b03e18eff0d1c55c77361da04@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00171.txt.bz2 On 2017-01-10 10:50, Pedro Alves wrote: > On 01/03/2017 04:17 PM, Simon Marchi wrote: > >> Right, now that I re-read it, it does sound funny. Fixed locally to: >> >> /* There is a former output pushed on the ui_out_redirect stack. >> We >> want to replace it by OUTPUT so we must pop the former value >> - first. We should either do both the pop and push or to do >> - neither of it. At least do not try to push OUTPUT if the pop >> - already failed. */ >> + first. Ideally, we should either do both the pop and push or do >> + neither of them. */ >> >> Thanks! > > OK with that change. > > BTW, also spotted a spurious whitespace after "*" here: > > > @@ -163,7 +163,7 @@ class ui_out > > ATTRIBUTE_PRINTF (2,0) = 0; > > virtual void do_wrap_hint (const char *identstring) = 0; > > virtual void do_flush () = 0; > > - virtual int do_redirect (struct ui_file * outstream) = 0; > > + virtual void do_redirect (struct ui_file * outstream) = 0; > > Thanks, > Pedro Alves Oh, right, same in cli-out.h and mi-out.h. I fixed them all and pushed, thanks.