From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zXtyMwFL6mVDFj0AWB0awg (envelope-from ) for ; Thu, 07 Mar 2024 18:17:21 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tWZL/+Pz; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NZeRrqqW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tWZL/+Pz; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NZeRrqqW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BE9591E0D2; Thu, 7 Mar 2024 18:17:21 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 303001E030 for ; Thu, 7 Mar 2024 18:17:19 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 27294385782F for ; Thu, 7 Mar 2024 23:17:18 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id B28023858D35 for ; Thu, 7 Mar 2024 23:16:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B28023858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B28023858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709853419; cv=none; b=oSgBjSZgnMnCRtDV1OYS7Yna6S430wmD141cUFbXzTgD7KS61CIE8DZwcDJbfDftHoLPXqyunfQYbMgFJAFu+c5wviKKCjExqevFfezbhc5S1fZpdT+hN+JvSckAIfKoKyDNMrtxxNRu2FB4DrJZhdZ/sKdSl8vEc3pC7z1SgJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709853419; c=relaxed/simple; bh=7ZIeuI/gzhIQTf78YWwvjicVLUf40Lkjxfq4bG67Whc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=laNFfcQTdvJTJ/6ecYCLYMRVOtWIT+R4OI5QLAUYvDen2LpRX88lpOJHqUe4C5jkR7Mb2w2d25bdbsNlFwcKOqAGxB/UUSG3KGKgJr4GQYGRuohWeKnAzR0L+zZgfX3W0M1dZQSj51/Tm7mc1GrrFnDpZX/YiGEeQxB8CqG+8Mg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AD9CB8D026; Thu, 7 Mar 2024 18:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709835775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXgtbUMzBmIbhqU6Wx5ZNAVfIUme/MUaRFhCavBEYnc=; b=tWZL/+PzRsLqLNW60DX5+V9g0y1Tg0N3QBgAZWJWVW0rMTv4YLAm21UX+DUKLLcmcSjEB5 lmsCsXZaTUKARNX1DUXdEnfzAZUai2rOT0RmLJWTeF6Sgu10Mi+Sj0G+SvGSwc3Sz+4j0D SJwc5KGYycyVnAyR8E4qJWQo3O2yXnU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709835775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXgtbUMzBmIbhqU6Wx5ZNAVfIUme/MUaRFhCavBEYnc=; b=NZeRrqqWpIdU38M81ohRr/2hXkHvkdlL0IvOewBAFsMhn9AIRYQabJEeqTim+GV1moDMIW JxUrwJj68yosvkCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709835775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXgtbUMzBmIbhqU6Wx5ZNAVfIUme/MUaRFhCavBEYnc=; b=tWZL/+PzRsLqLNW60DX5+V9g0y1Tg0N3QBgAZWJWVW0rMTv4YLAm21UX+DUKLLcmcSjEB5 lmsCsXZaTUKARNX1DUXdEnfzAZUai2rOT0RmLJWTeF6Sgu10Mi+Sj0G+SvGSwc3Sz+4j0D SJwc5KGYycyVnAyR8E4qJWQo3O2yXnU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709835775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HXgtbUMzBmIbhqU6Wx5ZNAVfIUme/MUaRFhCavBEYnc=; b=NZeRrqqWpIdU38M81ohRr/2hXkHvkdlL0IvOewBAFsMhn9AIRYQabJEeqTim+GV1moDMIW JxUrwJj68yosvkCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 93D69136C7; Thu, 7 Mar 2024 18:22:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4jJWIv8F6mU6EwAAD6G6ig (envelope-from ); Thu, 07 Mar 2024 18:22:55 +0000 Message-ID: <48d383e0-04f3-494c-954f-f399ab2b2c8c@suse.de> Date: Thu, 7 Mar 2024 19:23:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols Content-Language: en-US To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240214091712.223928-2-blarsen@redhat.com> <20240214091712.223928-4-blarsen@redhat.com> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.33 X-Spamd-Result: default: False [-1.33 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.04)[59.06%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/7/24 10:11, Guinevere Larsen wrote: > On 06/03/2024 18:16, Tom de Vries wrote: >> On 2/14/24 10:17, Guinevere Larsen wrote: >>> The test gdb.threads/threadcrash.exp demanded GDB to fully unwind and >>> print the names of all functions. However, some of the functions are >>> from the libc library, and so the test implicitly demanded libc symbols >>> to be available, and would fail otherwise, as was raised in PR >>> gdb/31293. >>> >>> This commit changes it so we only explicitly check for functions that >>> are provided by threadcrash.c to fix that >> >> Hi Gwen, >> >> Nit: Missing dot at end of line. >> >> With that fixed, LGTM. >> >> Approved-By: Tom de Vries > > Thanks for the review! > > Would this apply to both patches or just this second one? > Just this one, but after looking at the other patch, I realize also this patch is not ideal: if there are libc symbols for sleep and pthread_kill in the live_inferior case, they also should be there for the other cases. I'm working on a patch series based on yours, addressing this and a few more issues, hoping to submit tomorrow. Thanks, - Tom