Re: [PATCH][gdb/symtab] Prefer def over decl (inter-CU case, with context)

[Tom de Vries <tdevries@suse.de>]

On 09-04-2020 23:08, Tom de Vries wrote:
> Hi,
> 
> This is a follow-up patch on "[PATCH][gdb/symtab] Prefer def over decl
> (inter-CU case)" (
> https://sourceware.org/pipermail/gdb-patches/2020-April/167489.html ).
> 
> Consider the test-case from that patch.  It contains a decl and def of var a
> in different CUs, and tests whether var a can be printed using the def, even
> if the decl is found first.
> 
> However, the test-case does this in a contextless environment, so if we add to
> the test-case like this to set the context to the CU containing main:
> ...
>  gdb_test "p a" { = \{1, 2\}}
> +
> +if ![runto_main] then {
> +    fail "can't run to main"
> +    return 0
> +}
> +
> +gdb_test "p a" { = \{1, 2\}}
> ...
> then the second test fails, because the decl is found in the context.
> 
> Fix this by preferring defs over decls in lookup_global_symbol.
> 
> Build and reg-tested on x86_64-linux.
> 

Committed.

Thanks,
- Tom