From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-141875-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3862 invoked by alias); 21 Sep 2017 09:56:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3849 invoked by uid 89); 21 Sep 2017 09:56:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 09:56:44 +0000
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 91920356D9;	Thu, 21 Sep 2017 09:56:43 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 91920356D9
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id BEEDD60F89;	Thu, 21 Sep 2017 09:56:42 +0000 (UTC)
Subject: Re: [RFA 59/67] Constify some commands in infcmd.c
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-60-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <48a3bfdb-8b74-2644-f559-aade1e646fa4@redhat.com>
Date: Thu, 21 Sep 2017 09:56:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170921051023.19023-60-tom@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-09/txt/msg00609.txt.bz2

On 09/21/2017 06:10 AM, Tom Tromey wrote:
> @@ -2230,21 +2222,20 @@ set_environment_command (char *arg, int from_tty)
>    while (p != arg && (p[-1] == ' ' || p[-1] == '\t'))
>      p--;
>  
> -  var = savestring (arg, p - arg);
> +  std::string var (arg, p - arg);
>    if (nullset)
>      {
>        printf_filtered (_("Setting environment variable "
>  			 "\"%s\" to null value.\n"),
> -		       var);
> -      current_inferior ()->environment.set (var, "");
> +		       var.c_str ());
> +      current_inferior ()->environment.set (var.c_str (), "");
>      }
>    else
> -    current_inferior ()->environment.set (var, val);
> -  xfree (var);
> +    current_inferior ()->environment.set (var.c_str (), val);
>  }

Nice, this fixes a potential leak.  OK.

Thanks,
Pedro Alves