Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Wei-min Pan <weimin.pan@oracle.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org, Yao Qi <qiyaoltc@gmail.com>
Subject: Re: [PATCH PR gdb/18071] TLS variables can't be resolved on aarch64-linux-gnu
Date: Sat, 24 Mar 2018 20:16:00 -0000	[thread overview]
Message-ID: <48a0a2d8-09a6-1159-8192-8d102ff100b3@oracle.com> (raw)
In-Reply-To: <88889d0ddb7b55c57462cc482246c09b@simark.ca>



On 3/24/2018 12:52 PM, Simon Marchi wrote:
> On 2018-03-24 15:45, Wei-min Pan wrote:
>> Will submit a revised patch which
>>
>>  (1) calls lookup_bound_minimal_symbol in info_address_command() and
>>  (2) corrects the doc for lookup_minimal_symbol_and_objfile() in 
>> minsyms.h.
>
> I did (2) when pushing your patch (I just removed the mention about it 
> only looking through linkage names).  But I think the idea now would 
> be to get rid of lookup_minimal_symbol_and_objfile, since it's 
> basically the same as lookup_bound_minimal_symbol, isn't it?
>

Big difference is  lookup_minimal_symbol_and_objfile(char *name) only 
searches the ordinary hash table for "name"
while lookup_bound_minimal_symbol(char *name) does both the ordinary 
hash table  and the demangled hash table.


> Simon


  reply	other threads:[~2018-03-24 20:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03  0:54 Weimin Pan
2017-11-16  9:13 ` Yao Qi
2017-11-16 14:59   ` Yao Qi
2017-11-16 22:40   ` Wei-min Pan
2017-11-21 15:36     ` Yao Qi
2017-11-29  1:35       ` Weimin Pan
2018-03-17 16:52 ` Simon Marchi
2018-03-19 19:36   ` Weimin Pan
2018-03-22  4:22     ` Simon Marchi
2018-03-22 18:18       ` Wei-min Pan
2018-03-22 20:16         ` Simon Marchi
2018-03-22 20:49           ` Wei-min Pan
2018-03-24  3:10             ` Simon Marchi
2018-03-24 19:45               ` Wei-min Pan
2018-03-24 19:52                 ` Simon Marchi
2018-03-24 20:16                   ` Wei-min Pan [this message]
2018-03-24 20:44                     ` Simon Marchi
2018-03-24 21:42                       ` Wei-min Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48a0a2d8-09a6-1159-8192-8d102ff100b3@oracle.com \
    --to=weimin.pan@oracle.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox