From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25313 invoked by alias); 22 Oct 2008 03:53:19 -0000 Received: (qmail 25119 invoked by uid 22791); 22 Oct 2008 03:53:18 -0000 X-Spam-Check-By: sourceware.org Received: from yx-out-1718.google.com (HELO yx-out-1718.google.com) (74.125.44.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Oct 2008 03:52:37 +0000 Received: by yx-out-1718.google.com with SMTP id 3so721435yxi.48 for ; Tue, 21 Oct 2008 20:52:35 -0700 (PDT) Received: by 10.100.6.13 with SMTP id 13mr11036306anf.70.1224647555001; Tue, 21 Oct 2008 20:52:35 -0700 (PDT) Received: from 187.0.71.10.in-addr.arpa (70.43.3.242.nw.nuvox.net [70.43.3.242]) by mx.google.com with ESMTPS id b37sm20142552ana.33.2008.10.21.20.52.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 21 Oct 2008 20:52:33 -0700 (PDT) Message-ID: <48FEA381.3020509@gnu.org> Date: Wed, 22 Oct 2008 03:53:00 -0000 From: Paolo Bonzini User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: RFA: Save LDFLAGS and CPPFLAGS at the top level References: <20081021201533.GA17491@caradoc.them.org> In-Reply-To: <20081021201533.GA17491@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00535.txt.bz2 Daniel Jacobowitz wrote: > This patch should make all of {CPP,LD}FLAGS{,_FOR_TARGET,_FOR_BUILD} > work from the top level. The GDB simulator directories don't always > listen to them (partially tested patch posted), and I'm sure there are > other omissions, but this fixes what I could find by inspection. > > Tested by building an arm-none-eabi simulator for both current Linux > host and cross-built Windows host, with CPPFLAGS/LDFLAGS set before > running configure, and checking every command in the log. Without > this patch those CPPFLAGS and LDFLAGS are not used, with it they are. > > OK? Yes, thanks. Paolo