From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21176 invoked by alias); 20 Oct 2008 08:41:50 -0000 Received: (qmail 21166 invoked by uid 22791); 20 Oct 2008 08:41:49 -0000 X-Spam-Check-By: sourceware.org Received: from eu1sys200aob017.obsmtp.com (HELO eu1sys200aob017.obsmtp.com) (207.126.144.121) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Oct 2008 08:41:06 +0000 Received: from source ([164.129.1.35]) (using TLSv1) by eu1sys200aob017.postini.com ([207.126.147.11]) with SMTP; Mon, 20 Oct 2008 08:40:56 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 620ADDA4D for ; Mon, 20 Oct 2008 08:40:56 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3B0C54C061 for ; Mon, 20 Oct 2008 08:40:56 +0000 (GMT) Received: from crx595.cro.st.com (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.8.7a) with ESMTP id CQE05843 (AUTH "denis pilat"); Mon, 20 Oct 2008 10:42:01 +0200 (CEST) Message-ID: <48FC4417.2030807@st.com> Date: Mon, 20 Oct 2008 08:41:00 -0000 From: Denis PILAT User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: gdb-patches Subject: Mingw gdb validation Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00484.txt.bz2 Is there any chance for such a patch to be accepted ? It allows the following test to be successful when using a MinGW gdb (means a gdb compiled under MSYS environment or using CFLAGS="-mno-cygwin" under cygwin). If yes I will write a correct changelog entry. The following $nl value is the only one that works both on linux and windows when running a validation. About gdb.cp/userdef.exp, I don't understand why only in part of the tests we have a \r\n expected as the answer ? gdb_test "print one % two" "\\\$\[0-9\]* = {x = 2, y = 3}" gdb_test "print one && two" "\\\$\[0-9\]* = 1\[\r\n\]" <===== Why expecting \r\n here and not above ? -- Denis Index: ovldbreak.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/ovldbreak.exp,v retrieving revision 1.10 diff -u -p -r1.10 ovldbreak.exp --- ovldbreak.exp 3 Apr 2008 21:42:33 -0000 1.10 +++ ovldbreak.exp 17 Oct 2008 12:12:41 -0000 @@ -22,6 +22,7 @@ # tests for overloaded member functions. Set breakpoints on # overloaded member functions # +set nl "\[\r\n\]*" if $tracelevel then { @@ -130,7 +131,7 @@ proc set_bp_overloaded {name expectedmen # Note the arg type variations on lines 6 and 13. # This accommodates different versions of g++. -set menu_overload1arg "\\\[0\\\] cancel\r\n\\\[1\\\] all\r\n\\\[2\\\] foo::overload1arg\\(double\\) at.*$srcfile:121\r\n\\\[3\\\] foo::overload1arg\\(float\\) at.*$srcfile:120\r\n\\\[4\\\] foo::overload1arg\\(unsigned long\\) at.*$srcfile:119\r\n\\\[5\\\] foo::overload1arg\\(long\\) at.*$srcfile:118\r\n\\\[6\\\] foo::overload1arg\\((unsigned int|unsigned)\\) at.*$srcfile:117\r\n\\\[7\\\] foo::overload1arg\\(int\\) at.*$srcfile:116\r\n\\\[8\\\] foo::overload1arg\\(unsigned short\\) at.*$srcfile:115\r\n\\\[9\\\] foo::overload1arg\\(short\\) at.*$srcfile:114\r\n\\\[10\\\] foo::overload1arg\\(unsigned char\\) at.*$srcfile:113\r\n\\\[11\\\] foo::overload1arg\\(signed char\\) at.*$srcfile:112\r\n\\\[12\\\] foo::overload1arg\\(char\\) at.*$srcfile:111\r\n\\\[13\\\] foo::overload1arg\\((void|)\\) at.*$srcfile:110\r\n> $" +set menu_overload1arg "\\\[0\\\] cancel$nl\\\[1\\\] all$nl\\\[2\\\] foo::overload1arg\\(double\\) at.*$srcfile:121$nl\\\[3\\\] foo::overload1arg\\(float\\) at.*$srcfile:120$nl\\\[4\\\] foo::overload1arg\\(unsigned long\\) at.*$srcfile:119$nl\\\[5\\\] foo::overload1arg\\(long\\) at.*$srcfile:118$nl\\\[6\\\] foo::overload1arg\\((unsigned int|unsigned)\\) at.*$srcfile:117$nl\\\[7\\\] foo::overload1arg\\(int\\) at.*$srcfile:116$nl\\\[8\\\] foo::overload1arg\\(unsigned short\\) at.*$srcfile:115$nl\\\[9\\\] foo::overload1arg\\(short\\) at.*$srcfile:114$nl\\\[10\\\] foo::overload1arg\\(unsigned char\\) at.*$srcfile:113$nl\\\[11\\\] foo::overload1arg\\(signed char\\) at.*$srcfile:112$nl\\\[12\\\] foo::overload1arg\\(char\\) at.*$srcfile:111$nl\\\[13\\\] foo::overload1arg\\((void|)\\) at.*$srcfile:110$nl> $" # Set multiple-symbols to "ask", to allow us to test the use # of the multiple-choice menu when breaking on an overloaded method. Index: userdef.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/userdef.exp,v retrieving revision 1.10 diff -u -p -r1.10 userdef.exp --- userdef.exp 1 Jan 2008 22:53:19 -0000 1.10 +++ userdef.exp 17 Oct 2008 12:12:41 -0000 @@ -19,6 +19,7 @@ # # source file "userdef.cc" # +set nl "\[\r\n\]*" if $tracelevel then { strace $tracelevel @@ -94,9 +95,9 @@ gdb_test "print one / two" "\\\$\[0-9\]* gdb_test "print one % two" "\\\$\[0-9\]* = {x = 2, y = 3}" -gdb_test "print one && two" "\\\$\[0-9\]* = 1\[\r\n\]" +gdb_test "print one && two" "\\\$\[0-9\]* = 1$nl" -gdb_test "print one || two" "\\\$\[0-9\]* = 1\[\r\n\]" +gdb_test "print one || two" "\\\$\[0-9\]* = 1$nl" gdb_test "print one & two" "\\\$\[0-9\]* = {x = 0, y = 1}" @@ -104,17 +105,17 @@ gdb_test "print one | two" "\\\$\[0-9\]* gdb_test "print one ^ two" "\\\$\[0-9\]* = {x = 6, y = 6}" -gdb_test "print one < two" "\\\$\[0-9\]* = 1\[\r\n\]" +gdb_test "print one < two" "\\\$\[0-9\]* = 1$nl" -gdb_test "print one <= two" "\\\$\[0-9\]* = 1\[\r\n\]" +gdb_test "print one <= two" "\\\$\[0-9\]* = 1$nl" -gdb_test "print one > two" "\\\$\[0-9\]* = 0\[\r\n\]" +gdb_test "print one > two" "\\\$\[0-9\]* = 0$nl" -gdb_test "print one >= two" "\\\$\[0-9\]* = 0\[\r\n\]" +gdb_test "print one >= two" "\\\$\[0-9\]* = 0$nl" -gdb_test "print one == two" "\\\$\[0-9\]* = 0\[\r\n\]" +gdb_test "print one == two" "\\\$\[0-9\]* = 0$nl" -gdb_test "print one != two" "\\\$\[0-9\]* = 1\[\r\n\]" +gdb_test "print one != two" "\\\$\[0-9\]* = 1$nl" # Can't really check the output of this one without knowing # target integer width. Make sure we don't try to call @@ -124,7 +125,7 @@ gdb_test "print one << 31" "\\\$\[0-9\]* # Should be fine even on < 32-bit targets. gdb_test "print one >> 31" "\\\$\[0-9\]* = {x = 0, y = 0}" -gdb_test "print !one" "\\\$\[0-9\]* = 0\[\r\n\]" +gdb_test "print !one" "\\\$\[0-9\]* = 0$nl" # Assumes 2's complement. So does everything... gdb_test "print +one" "\\\$\[0-9\]* = {x = 2, y = 3}"